Skip to content

[Android] Fixed: SearchHandler not displaying default search and clear icons #29981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,22 @@ AImageButton CreateImageButton(Context context, BindableObject bindable, Bindabl
result.Focusable = false;
result.SetScaleType(ImageView.ScaleType.FitCenter);

if (bindable.GetValue(property) is ImageSource image)
AutomationPropertiesProvider.SetContentDescription(result, image, null, null);
var imageSource = bindable.GetValue(property) as ImageSource;

((ImageSource)bindable.GetValue(property)).LoadImage(MauiContext, (r) =>
if (imageSource is not null)
{
result.SetImageDrawable(r?.Value);
});
AutomationPropertiesProvider.SetContentDescription(result, imageSource, null, null);

imageSource.LoadImage(MauiContext, r =>
{
result.SetImageDrawable(r?.Value);
});
}
else if (defaultImage != -1)
{
// If the icon is not set, use the default icon
result.SetImageResource(defaultImage);
Copy link
Preview

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default icons set via SetImageResource lack a content description, which may hinder accessibility; consider calling AutomationPropertiesProvider.SetContentDescription with a suitable description for the default icons.

Suggested change
result.SetImageResource(defaultImage);
result.SetImageResource(defaultImage);
AutomationPropertiesProvider.SetContentDescription(result, "Default icon", null, null);

Copilot uses AI. Check for mistakes.

}

var lp = new LinearLayout.LayoutParams((int)Context.ToPixels(22), LP.MatchParent)
{
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 44 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue29973.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
namespace Maui.Controls.Sample.Issues;

[Issue(IssueTracker.Github, 29973, "[Android] SearchHandler default icons are not displayed correctly", PlatformAffected.Android)]
public class Issue29973 : TestShell
{
protected override void Init()
{
FlyoutBehavior = FlyoutBehavior.Flyout;

var searchHandler = new SearchHandler
{
Placeholder = "Search here",
PlaceholderColor = Colors.Blue
};

var button = new Button
{
Text = "Set SearchHandler Values",
AutomationId = "valueButton",
HorizontalOptions = LayoutOptions.Center,
VerticalOptions = LayoutOptions.Center
};

button.Clicked += (s, e) =>
{
searchHandler.Query = "Maui";
};

var contentPage = new ContentPage
{
Title = "Home",
Content = button
};

SetSearchHandler(contentPage, searchHandler);

Items.Add(new ShellContent
{
Title = "Home",
Route = "MainPage",
Content = contentPage
});
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues;

public class Issue29973 : _IssuesUITest
{
public override string Issue => "[Android] SearchHandler default icons are not displayed correctly";

public Issue29973(TestDevice device)
: base(device)
{ }

[Test]
[Category(UITestCategories.Shell)]
public void VerifySearchHandlerDefaultIcons()
{
App.WaitForElement("valueButton");
App.Tap("valueButton");
VerifyScreenshot();
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading