-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fixed: SearchHandler not displaying default search and clear icons #29981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Tamilarasan-Paranthaman
wants to merge
1
commit into
dotnet:main
from
Tamilarasan-Paranthaman:SearchHandler-Default-Icons
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+23.7 KB
...s/TestCases.Android.Tests/snapshots/android/VerifySearchHandlerDefaultIcons.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
namespace Maui.Controls.Sample.Issues; | ||
|
||
[Issue(IssueTracker.Github, 29973, "[Android] SearchHandler default icons are not displayed correctly", PlatformAffected.Android)] | ||
public class Issue29973 : TestShell | ||
{ | ||
protected override void Init() | ||
{ | ||
FlyoutBehavior = FlyoutBehavior.Flyout; | ||
|
||
var searchHandler = new SearchHandler | ||
{ | ||
Placeholder = "Search here", | ||
PlaceholderColor = Colors.Blue | ||
}; | ||
|
||
var button = new Button | ||
{ | ||
Text = "Set SearchHandler Values", | ||
AutomationId = "valueButton", | ||
HorizontalOptions = LayoutOptions.Center, | ||
VerticalOptions = LayoutOptions.Center | ||
}; | ||
|
||
button.Clicked += (s, e) => | ||
{ | ||
searchHandler.Query = "Maui"; | ||
}; | ||
|
||
var contentPage = new ContentPage | ||
{ | ||
Title = "Home", | ||
Content = button | ||
}; | ||
|
||
SetSearchHandler(contentPage, searchHandler); | ||
|
||
Items.Add(new ShellContent | ||
{ | ||
Title = "Home", | ||
Route = "MainPage", | ||
Content = contentPage | ||
}); | ||
} | ||
} |
23 changes: 23 additions & 0 deletions
23
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29973.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
||
public class Issue29973 : _IssuesUITest | ||
{ | ||
public override string Issue => "[Android] SearchHandler default icons are not displayed correctly"; | ||
|
||
public Issue29973(TestDevice device) | ||
: base(device) | ||
{ } | ||
|
||
[Test] | ||
[Category(UITestCategories.Shell)] | ||
public void VerifySearchHandlerDefaultIcons() | ||
{ | ||
App.WaitForElement("valueButton"); | ||
App.Tap("valueButton"); | ||
VerifyScreenshot(); | ||
} | ||
} |
Binary file added
BIN
+30.9 KB
...ols/tests/TestCases.iOS.Tests/snapshots/ios/VerifySearchHandlerDefaultIcons.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default icons set via SetImageResource lack a content description, which may hinder accessibility; consider calling AutomationPropertiesProvider.SetContentDescription with a suitable description for the default icons.
Copilot uses AI. Check for mistakes.