[iOS] Support for IsSwipeEnabled on CarouselView2 #29996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for disabling swipe gestures on CarouselView2 on iOS by adding a new test case and updating the iOS layout logic. It includes new automated tests, updates to the host app UI, and modifications to the iOS layout factory to conditionally adjust scrolling based on the IsSwipeEnabled flag.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29391.cs | Added automated test verifying swipe behavior changes on CarouselView |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29391.xaml.cs | New host app partial class for Issue29391 |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29391.xaml | Updated XAML to bind IsSwipeEnabled to a Switch control |
| src/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs | Updated layout logic on iOS to respect the IsSwipeEnabled property |
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs:287
- [nitpick] Consider adding a comment to explain the logic behind computing 'lastPosition' here, particularly clarifying why 'Position + 1' is used when looping.
int lastPosition = itemsView.Loop ? itemsView.Position + 1 : itemsView.Position;
src/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs:341
- [nitpick] Please add a comment explaining the early return when swipe is disabled, and how it affects subsequent logic in the layout update.
if (!itemsView.IsSwipeEnabled)
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rmarinho
requested changes
Jun 16, 2025
jsuarezruiz
requested changes
Jun 16, 2025
|
@rmarinho @jsuarezruiz can we please try to rerun tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
This PR adds proper support for the IsSwipeEnabled property on CarouselView2 for iOS. Currently, setting IsSwipeEnabled to false does not disable user swipe gestures as expected. This behavior is inconsistent and may lead to confusion or unintended navigation in applications.
Issues Fixed
Fixes #29391
Screen.Recording.2025-06-15.at.11.57.54.mov
Screen.Recording.2025-06-15.at.11.56.39.mov