[iOS, Mac] Fix for downsized image retaining original dimensions in GraphicsView #30007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where downsized images retained their original dimensions on iOS by using the desired target size when creating the image renderer, and adds UI tests to verify the behavior across platforms.
- Use the provided
sizeinstead oftarget.Sizewhen initializingUIGraphicsImageRendererinScaleImage. - Introduce a new UI test in
TestCases.Shared.Teststo confirm the downsized image dimensions. - Add a HostApp page and embed the test image resource to exercise and validate the fix.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Graphics/src/Graphics/Platforms/iOS/UIImageExtensions.cs | Changed renderer initialization to use size instead of target.Size. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30006.cs | Added a UI test for verifying that downsized images have the expected dimensions. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue30006.cs | Created a HostApp page with buttons and labels to reproduce and validate the fix. |
| src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj | Embedded royals.png as a resource for the HostApp test. |
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30006.cs:1
- The test is conditionally compiled only when TEST_FAILS_ON_WINDOWS, which prevents it from running on Windows now that the bug is fixed. Please remove the #if...#endif directives so the test executes on all platforms.
#if TEST_FAILS_ON_WINDOWS // Issue Link - https://github.com/dotnet/maui/issues/16767
src/Controls/tests/TestCases.HostApp/Issues/Issue30006.cs:19
- [nitpick] The variable name
VerticalStackLayoutconflicts with its type and uses PascalCase. Rename it to something likeverticalStackLayoutorlayoutfor clarity.
VerticalStackLayout VerticalStackLayout = new VerticalStackLayout
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Jun 18, 2025
PureWeen
approved these changes
Jun 18, 2025
mattleibow
approved these changes
Jun 18, 2025
|
/backport to release/9.0.1xx-sr8 |
|
Started backporting to release/9.0.1xx-sr8: https://github.com/dotnet/maui/actions/runs/15743655600 |
PureWeen
pushed a commit
that referenced
this pull request
Jun 21, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
PureWeen
added a commit
that referenced
this pull request
Jun 28, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - Inflight/Candidate Branch ## What's Changed ### MAUI Product Fixes * [iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fixes #26863 by @kubaflo in #26868 * Fixes Setting BackgroundColor to null does not actually changes BackgroundColor - fixes #22914 and #19576 by @jgonzalez-gft in #22917 * Fixed the picker title's color - fixes #16737 by @kubaflo in #23075 * [android] Fallback to default icons in SearchHandler by @aheubusch in #25067 * ScrollView's Background on iOS - fixes #24016 by @kubaflo in #25541 * [iOS] Enabled MultiTouch Support for Handling Multi-Touch Points in GraphicsView - fixes #29461 by @prakashKannanSf3972 in #29895 * Optimize converters for GridLength, ColumnDefinition, and RowDefinition - performance improvement by @emiller in #20048 * Add defensive IsAlive check to Android ViewExtensions.OnUnloaded - fixes #28051 by @jfversluis in #29934 * [Windows] Fixed runtime update issue for SearchBar PlaceholderColor and BackgroundColor - fixes #29962 by @Tamilarasan-Paranthaman in #29965 * Weak subscription to CanExecuteChange events - fixes #16124 by @sneumaier in #29837 * [iOS, Mac] Fix for downsized image retaining original dimensions in GraphicsView - fixes #30006 by @SyedAbdulAzeemSF4852 in #30007 * [Android] Prevent Picker from Gaining Focus on Touch - fixes #19739, #8546, #13503, #24862, #28121, #21704, #15394 by @bhavanesh2001 in #29068 * Fix CV1 GridItemsLayout centering single item AND Fix Empty view not resizing when bounds change - fixes #29595, #29634 by @albyrock87 in #29639 ### Testing * [Testing] Feature Matrix UITest Cases for Button by @TamilarasanSF4853 in #29803 * [Testing] Feature matrix UITest Cases for BoxView Control by @HarishKumarSF4517 in #29808 * [Testing] Enable HandlerDoesNotLeak for Button and ProgressBar by @bhavanesh2001 in #29896 * [Testing] Add Validation Test For Issue28051 On Android by @prakashKannanSf3972 in #30026 * [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate by @HarishKumarSF4517 in #30136 ### Dependency Updates * Bump to 1.7.250606001 of WindowsAppSDK by @sneumaier in #29915 ### Housekeeping * [housekeeping] Update namespaces in HostApp and Shared tests projects by @bhavanesh2001 in #29904 * Update SetterSpecificity.cs Remove Extra Line From Bad Merge by @sneumaier in #29987 * Revert - Fixed the Label not sized correctly on Android by @Ahamed-Ali in #30023 * Revert "Fixes Setting BackgroundColor to null does not actually changes BackgroundColor #22914 (#22917)" by @mattleibow in #30031 * [create-pull-request] automated change by @github-actions[bot] in #30019 * [create-pull-request] automated change by @github-actions[bot] in #30043 * [create-pull-request] automated change by @github-actions[bot] in #30078 * Update Controls.TestCases.HostApp.csproj by @HarishKumarSF4517 in #30124 ## New Contributors * @albyrock87 made their first contribution in #29639 * @SyedAbdulAzeemSF4852 made their first contribution in #30007 * @emiller made their first contribution in #20048 * @jgonzalez-gft made their first contribution in #22917 * @aheubusch made their first contribution in #25067 **Full Changelog**: https://github.com/dotnet/maui/compare/main..inflight/candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Root Cause
Description of Change
The renderer was updated to use the desired target size (size) instead of the original image size when creating the UIGraphicsImageRenderer. This ensures that the resulting image is actually created at the resized dimensions.
This PR caused a regression that led to the issue.
Issues Fixed
Fixes #30006
Validated the behaviour in the following platforms
Output
Before.mov
After.mov