[Android] Propagate the KeyEvents from Modal pages to MainActivity #30087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Starchm! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
reviewed
Jun 27, 2025
| return activity.OnKeyLongPress(keyCode, e); | ||
| } | ||
|
|
||
| public override bool OnKeyDown([GeneratedEnum] Keycode keyCode, KeyEvent e) |
There was a problem hiding this comment.
I worry about firing through to the activity methods because that is going to possibly trigger other side effects
Here's the source code on onKeyUp from android
@Override
public boolean onKeyDown(int keyCode, KeyEvent event) {
if (performMenuItemShortcut(event)) {
return true;
}
return super.onKeyDown(keyCode, event);
}I'm not too sure the best path to take here
It seems like the keylistener and keyevent doesn't really express enough to be useful
Long term I think we could pipe these through platform lifecycle events but I know that doesn't super help right now in net9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Calls the MainActivity overrides from the ComponentDialog's overrides, so the previous behavior of KeyEvent handling of Modal pages is restored.
Issues Fixed
Fixes #30048