Fixed GetStringSize() is not consistent with actual string size in GraphicsView #30133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Dhivya-SF4094! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
added
the
area-drawing
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Jun 24, 2025
@jsuarezruiz I have resaved the image for the failing GraphicsViewShouldNotWrapText test case. Could you please review once. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-18679
branch
from
3b4ca01 to
04cfc7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Detail
When drawing text and its bounding rectangle in GraphicsView using canvas.GetStringSize(string), the measured size is insufficient, causing the text to overflow the rectangle.
Root Cause
String size was calculated inaccurately on iOS and Windows, causing text to overflow the measured rectangle in GraphicsView.
Description of Change
iOS: Replaced NSString.GetBoundingRect with CTFramesetter.SuggestFrameSize, which provides a more accurate and layout-aware measurement of the text using CoreText. This results proper frame size of string text.
Windows: Replaced the previous bounding logic with CanvasTextLayout from Win2D to accurately measure text size. Word wrapping is disabled, and proper horizontal and vertical alignments are applied. The size is taken from LayoutBounds, with a fallback to DrawBounds to ensure the full text is enclosed.
Validated the behaviour in the following platforms
Issues Fixed:
Fixes #18679
Screenshots