Skip to content

[Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate #30136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HarishKumarSF4517
Copy link
Contributor

@HarishKumarSF4517 HarishKumarSF4517 commented Jun 23, 2025

Description

This pull request adds a couple of modifications to the Issue10025 test case to enhance its reliability. Also I have fixed the UI test image failures in this PR(#30115) and I have Resaved the UI Test Images.
Build link - https://dev.azure.com/xamarin/public/_build/results?buildId=144667&view=ms.vss-test-web.build-test-results-tab

Test case improvements:

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 23, 2025
Copy link
Contributor

Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jun 23, 2025
@HarishKumarSF4517 HarishKumarSF4517 changed the title [net10.0, Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate Jun 23, 2025
@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review June 23, 2025 14:48
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner June 23, 2025 14:48
@HarishKumarSF4517 HarishKumarSF4517 requested review from StephaneDelcroix and jfversluis and removed request for a team June 23, 2025 14:48
@anandhan-rajagopal anandhan-rajagopal added area-testing Unit tests, device tests test-flight labels Jun 23, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snapshot is pending in some platforms. Example, Mac:
image
But based on the snapshot, seems the test is failing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differences on Android:
Snapshot different than baseline: ScrollViewGradientBackground.png (7.19% difference)
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing on Windows:

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2460
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2477
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 681
   at Microsoft.Maui.TestCases.Tests.Issues.Issue24061.ScrollViewGradientBackgroundShouldWorkWithScrollView() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24061.cs:line 19
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubaflo , The newly added test cases from the candidate branch (456e29c) were causing increased flakiness and failures on Windows. I have redefined these test cases to use programmatic scrolling, significantly improving their reliability. The updated tests are passing consistently across all platforms.

For your reference, here is the commit link. a8b1031

@rmarinho , @jsuarezruiz , I have modified the above failure test cases. Can you retrigger the CI to get the Mac and Windows images for the respective tests?

@rmarinho
Copy link
Member

/azp run

@dotnet dotnet deleted a comment from azure-pipelines bot Jun 24, 2025
@dotnet dotnet deleted a comment from PureWeen Jun 24, 2025
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@anandhan-rajagopal
Copy link
Contributor

#30136 (comment) @rmarinho , @jsuarezruiz , I have modified the above failure test cases. Can you retrigger the CI to get the Mac and Windows images for the respective tests?

@dotnet dotnet deleted a comment from azure-pipelines bot Jun 25, 2025
@dotnet dotnet deleted a comment from jsuarezruiz Jun 25, 2025
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen force-pushed the inflight/candidate branch from ea65e77 to ea1b786 Compare June 25, 2025 21:57
@PureWeen
Copy link
Member

/rebase

1 similar comment
@PureWeen
Copy link
Member

/rebase

@PureWeen PureWeen force-pushed the harish_candidatefix_01 branch from d1d1600 to 3f0c2e4 Compare June 25, 2025 22:10
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 4aa9e0c into dotnet:inflight/candidate Jun 26, 2025
129 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
#30136)

* Resaved the Snapshots

* Update ImagePaintWithDownsize.png

* update mac image

* Updated test failures

* Added mac and windows images from CI

---------

Co-authored-by: Anandhan Rajagopal <[email protected]>
PureWeen pushed a commit that referenced this pull request Jun 27, 2025
#30136)

* Resaved the Snapshots

* Update ImagePaintWithDownsize.png

* update mac image

* Updated test failures

* Added mac and windows images from CI

---------

Co-authored-by: Anandhan Rajagopal <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
#30136)

* Resaved the Snapshots

* Update ImagePaintWithDownsize.png

* update mac image

* Updated test failures

* Added mac and windows images from CI

---------

Co-authored-by: Anandhan Rajagopal <[email protected]>
PureWeen added a commit that referenced this pull request Jun 28, 2025
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

# .NET MAUI Release Notes - Inflight/Candidate Branch

## What's Changed

### MAUI Product Fixes
* [iOS] CarouselView with CarouselViewHandler2 make app crash when
Loop="False" and user scroll to the last position - fixes #26863 by
@kubaflo in #26868
* Fixes Setting BackgroundColor to null does not actually changes
BackgroundColor - fixes #22914 and #19576 by @jgonzalez-gft in
#22917
* Fixed the picker title's color - fixes #16737 by @kubaflo in
#23075
* [android] Fallback to default icons in SearchHandler by @aheubusch in
#25067
* ScrollView's Background on iOS - fixes #24016 by @kubaflo in
#25541
* [iOS] Enabled MultiTouch Support for Handling Multi-Touch Points in
GraphicsView - fixes #29461 by @prakashKannanSf3972 in
#29895
* Optimize converters for GridLength, ColumnDefinition, and
RowDefinition - performance improvement by @emiller in
#20048
* Add defensive IsAlive check to Android ViewExtensions.OnUnloaded -
fixes #28051 by @jfversluis in #29934
* [Windows] Fixed runtime update issue for SearchBar PlaceholderColor
and BackgroundColor - fixes #29962 by @Tamilarasan-Paranthaman in
#29965
* Weak subscription to CanExecuteChange events - fixes #16124 by
@sneumaier in #29837
* [iOS, Mac] Fix for downsized image retaining original dimensions in
GraphicsView - fixes #30006 by @SyedAbdulAzeemSF4852 in
#30007
* [Android] Prevent Picker from Gaining Focus on Touch - fixes #19739,
#8546, #13503, #24862, #28121, #21704, #15394 by @bhavanesh2001 in
#29068
* Fix CV1 GridItemsLayout centering single item AND Fix Empty view not
resizing when bounds change - fixes #29595, #29634 by @albyrock87 in
#29639

### Testing
* [Testing] Feature Matrix UITest Cases for Button by @TamilarasanSF4853
in #29803
* [Testing] Feature matrix UITest Cases for BoxView Control by
@HarishKumarSF4517 in #29808
* [Testing] Enable HandlerDoesNotLeak for Button and ProgressBar by
@bhavanesh2001 in #29896
* [Testing] Add Validation Test For Issue28051 On Android by
@prakashKannanSf3972 in #30026
* [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate
by @HarishKumarSF4517 in #30136

### Dependency Updates
* Bump to 1.7.250606001 of WindowsAppSDK by @sneumaier in
#29915

### Housekeeping
* [housekeeping] Update namespaces in HostApp and Shared tests projects
by @bhavanesh2001 in #29904
* Update SetterSpecificity.cs Remove Extra Line From Bad Merge by
@sneumaier in #29987
* Revert - Fixed the Label not sized correctly on Android by @Ahamed-Ali
in #30023
* Revert "Fixes Setting BackgroundColor to null does not actually
changes BackgroundColor #22914 (#22917)" by @mattleibow in
#30031
* [create-pull-request] automated change by @github-actions[bot] in
#30019
* [create-pull-request] automated change by @github-actions[bot] in
#30043
* [create-pull-request] automated change by @github-actions[bot] in
#30078
* Update Controls.TestCases.HostApp.csproj by @HarishKumarSF4517 in
#30124

## New Contributors
* @albyrock87 made their first contribution in
#29639
* @SyedAbdulAzeemSF4852 made their first contribution in
#30007
* @emiller made their first contribution in
#20048
* @jgonzalez-gft made their first contribution in
#22917
* @aheubusch made their first contribution in
#25067

**Full Changelog**:
https://github.com/dotnet/maui/compare/main..inflight/candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration test-flight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants