[Windows]Fixed the ViewExtensions RotateYTo and RotateXTo with length 0 crashes #30167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
MartyIX
reviewed
Jun 24, 2025
| @@ -37,6 +37,10 @@ public static void UpdateTransformation(this FrameworkElement frameworkElement, | |||
| // rotation values are set, but the aforementioned functionality will be lost. | |||
| if (Math.Abs(view.RotationX) != 0 || Math.Abs(view.RotationY) != 0) | |||
There was a problem hiding this comment.
Is there any reason this is not
Suggested change
| if (Math.Abs(view.RotationX) != 0 || Math.Abs(view.RotationY) != 0) | |
| if (Math.Abs(rotationX) != 0 || Math.Abs(rotationY) != 0) |
?
There was a problem hiding this comment.
Now, I have reused the local variable @MartyIX
MartyIX
reviewed
Jun 24, 2025
| if (double.IsNaN(rotationX) || double.IsNaN(rotationY) || double.IsNaN(rotation)) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
btw: Given your patch, is it safe to pass NaN here:
?There was a problem hiding this comment.
Yes, it's safe to pass NaN in this case because no mathematical operations are performed on it, so no exception occurs. A valid value will be updated during the subsequent continuous updates. @MartyIX
MartyIX
reviewed
Jun 24, 2025
| @@ -0,0 +1,35 @@ | |||
| namespace Maui.Controls.Sample.Issues; | |||
|
|
|||
| [Issue(IssueTracker.Github, 18420, "[Windows]ViewExtensions RotateYTo and RotateXTo with length 0 crashes on Windows", PlatformAffected.UWP)] | |||
There was a problem hiding this comment.
Suggested change
| [Issue(IssueTracker.Github, 18420, "[Windows]ViewExtensions RotateYTo and RotateXTo with length 0 crashes on Windows", PlatformAffected.UWP)] | |
| [Issue(IssueTracker.Github, 18420, "[Windows] ViewExtensions RotateYTo and RotateXTo with length 0 crashes on Windows", PlatformAffected.UWP)] |
MartyIX
reviewed
Jun 24, 2025
| { | ||
| public Issue18420(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "[Windows]ViewExtensions RotateYTo and RotateXTo with length 0 crashes on Windows"; |
There was a problem hiding this comment.
Suggested change
| public override string Issue => "[Windows]ViewExtensions RotateYTo and RotateXTo with length 0 crashes on Windows"; | |
| public override string Issue => "[Windows] ViewExtensions RotateYTo and RotateXTo with length 0 crashes on Windows"; |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Tweener.cs#L124
Description of Change
Issues Fixed
Fixes #18420
Tested the behaviour in the following platforms
Screenshot
CrashOccured.mp4
NoCrashwithFix.mp4