Prevent the BlazorWebView bounce on iOS #30176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the bounce/overscroll behavior on iOS/macOS Catalyst for BlazorWebView by default and adds a device test to verify the new behavior.
- Add
Bounces,AlwaysBounceVertical, andAlwaysBounceHorizontaltoggles in the iOS handler tofalse. - Introduce a new device test (
BlazorWebViewScrollBounceDisabledByDefault) to validate the default scroll settings.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BlazorWebView/tests/MauiDeviceTests/Elements/BlazorWebViewTests.Behaviors.cs | New device test to assert bounce is disabled on iOS/Catalyst |
| src/BlazorWebView/src/Maui/iOS/BlazorWebViewHandler.iOS.cs | Disable scroll bounce properties by default |
Comments suppressed due to low confidence (1)
src/BlazorWebView/src/Maui/iOS/BlazorWebViewHandler.iOS.cs:115
- Update the public XML documentation in
/docs/to reflect that bounce scrolling is now disabled by default on iOS and MacCatalyst.
// Disable bounce scrolling to make Blazor apps feel more native
|
/rebase |
github-actions
bot
force-pushed
the
dev/ios-bounce
branch
from
29b92f2 to
de60821
Compare
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This reverts commit eae5211.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Disbale the buiny/overscroll by default on iOS since this is a hybrid app. No need for overscroll on titlebars. It is weird.
Better than #30169
Issues Fixed
Fixes #6689