Skip to content

Build the project first before formatting #30233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025
Merged

Build the project first before formatting #30233

merged 3 commits into from
Jun 26, 2025

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Jun 25, 2025

Description of Change

Right now, the formatting is not using a built project so it is not formatting all the right files.

@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 23:23
@mattleibow mattleibow requested a review from a team as a code owner June 25, 2025 23:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the repository is built before running dotnet format and updates workflow triggers for both daily formatting and Copilot setup workflows.

  • Adds a pre-build step, environment setup, and workspace reset before formatting
  • Enables the format workflow on pull requests (currently scoped to the workflow file)
  • Extends the Copilot setup workflow to trigger on pushes and pull requests to its YAML

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/dotnet-format-daily.yml Added pull_request trigger, pre-build, env vars, and reset steps
.github/workflows/copilot-setup-steps.yml Expanded on triggers to include push and pull_request
Comments suppressed due to low confidence (2)

.github/workflows/dotnet-format-daily.yml:6

  • The pull_request trigger is currently limited to changes in the workflow file itself, so formatting won’t run on PRs that change code. Consider broadening or removing the paths filter to cover code changes.
  pull_request:

.github/workflows/copilot-setup-steps.yml:3

  • There's a stray hyphen before on: which makes the YAML invalid. Remove the leading - so that the workflow trigger is parsed correctly.
on:

@mattleibow mattleibow changed the title Build the project forst before formatting Build the project first before formatting Jun 25, 2025
@mattleibow mattleibow merged commit 3d584fa into main Jun 26, 2025
8 checks passed
@mattleibow mattleibow deleted the dev/formatting branch June 26, 2025 00:26
NanthiniMahalingam pushed a commit to NanthiniMahalingam/maui that referenced this pull request Jun 27, 2025
* Build the project forst before formatting

* We may need to restore...

* Update dotnet-format-daily.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant