Build the project first before formatting #30233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the repository is built before running dotnet format and updates workflow triggers for both daily formatting and Copilot setup workflows.
- Adds a pre-build step, environment setup, and workspace reset before formatting
- Enables the format workflow on pull requests (currently scoped to the workflow file)
- Extends the Copilot setup workflow to trigger on pushes and pull requests to its YAML
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/dotnet-format-daily.yml | Added pull_request trigger, pre-build, env vars, and reset steps |
| .github/workflows/copilot-setup-steps.yml | Expanded on triggers to include push and pull_request |
Comments suppressed due to low confidence (2)
.github/workflows/dotnet-format-daily.yml:6
- The
pull_requesttrigger is currently limited to changes in the workflow file itself, so formatting won’t run on PRs that change code. Consider broadening or removing thepathsfilter to cover code changes.
pull_request:
.github/workflows/copilot-setup-steps.yml:3
- There's a stray hyphen before
on:which makes the YAML invalid. Remove the leading-so that the workflow trigger is parsed correctly.
on:
mattleibow
changed the title
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Jun 27, 2025
* Build the project forst before formatting * We may need to restore... * Update dotnet-format-daily.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Right now, the formatting is not using a built project so it is not formatting all the right files.