Remove .NET 8 specific code for templates #30342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
the
area-templates
There was a problem hiding this comment.
Pull Request Overview
This PR removes .NET 8–specific code from the mobile templates to clean up conditional code that is no longer needed now that .NET 8 is unsupported.
- Removed preprocessor directives and alternative flag settings in ManageMetaPage.xaml
- Removed conditional PackageReference for CommunityToolkit.Maui in MauiApp.1.csproj
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Templates/src/templates/maui-mobile/Pages/ManageMetaPage.xaml | Removed .NET 8–specific conditional flag setting from Entry.Behaviors |
| src/Templates/src/templates/maui-mobile/MauiApp.1.csproj | Removed .NET 8–specific PackageReference for CommunityToolkit.Maui |
Comments suppressed due to low confidence (2)
src/Templates/src/templates/maui-mobile/Pages/ManageMetaPage.xaml:64
- The removal of the .NET 8–specific preprocessor directive looks correct; please ensure that any documentation or release notes are updated to reflect that the ValidateOnUnfocusing flag is no longer supported.
InvalidStyle="{StaticResource InvalidEntryStyle}"
src/Templates/src/templates/maui-mobile/MauiApp.1.csproj:86
- Removing the conditional PackageReference for .NET 8 is appropriate; ensure that the change is clearly documented so that consumers know that version 9.1.0 of CommunityToolkit.Maui is no longer used.
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.3.2" />
jsuarezruiz
approved these changes
Jul 1, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
github-actions
bot
force-pushed
the
inflight/current
branch
from
c4d674b to
aebca98
Compare
PureWeen
pushed a commit
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Since .NET 8 is now out of support, this removes the .NET 8 specific code from the templates in the
src/Templates/src/templates/maui-mobiledirectory.Issues Fixed
Fixes #28800