Skip to content

Remove .NET 8 specific code for templates #30342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Conversation

jfversluis
Copy link
Member

Description of Change

Since .NET 8 is now out of support, this removes the .NET 8 specific code from the templates in the src/Templates/src/templates/maui-mobile directory.

Issues Fixed

Fixes #28800

@jfversluis jfversluis added this to the .NET 9 SR10 milestone Jul 1, 2025
@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 08:54
@jfversluis jfversluis added the area-templates Project templates, Item Templates for Blazor and MAUI label Jul 1, 2025
@jfversluis jfversluis requested a review from a team as a code owner July 1, 2025 08:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes .NET 8–specific code from the mobile templates to clean up conditional code that is no longer needed now that .NET 8 is unsupported.

  • Removed preprocessor directives and alternative flag settings in ManageMetaPage.xaml
  • Removed conditional PackageReference for CommunityToolkit.Maui in MauiApp.1.csproj

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Templates/src/templates/maui-mobile/Pages/ManageMetaPage.xaml Removed .NET 8–specific conditional flag setting from Entry.Behaviors
src/Templates/src/templates/maui-mobile/MauiApp.1.csproj Removed .NET 8–specific PackageReference for CommunityToolkit.Maui
Comments suppressed due to low confidence (2)

src/Templates/src/templates/maui-mobile/Pages/ManageMetaPage.xaml:64

  • The removal of the .NET 8–specific preprocessor directive looks correct; please ensure that any documentation or release notes are updated to reflect that the ValidateOnUnfocusing flag is no longer supported.
                                        InvalidStyle="{StaticResource InvalidEntryStyle}"

src/Templates/src/templates/maui-mobile/MauiApp.1.csproj:86

  • Removing the conditional PackageReference for .NET 8 is appropriate; ensure that the change is clearly documented so that consumers know that version 9.1.0 of CommunityToolkit.Maui is no longer used.
		<PackageReference Include="CommunityToolkit.Mvvm" Version="8.3.2" />

@jfversluis jfversluis moved this from Todo to Ready To Review in MAUI SDK Ongoing Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Jul 1, 2025
@PureWeen PureWeen changed the base branch from main to inflight/current July 1, 2025 16:17
@github-actions github-actions bot force-pushed the inflight/current branch from c4d674b to aebca98 Compare July 1, 2025 16:18
@PureWeen PureWeen merged commit 3e1a8e7 into inflight/current Jul 1, 2025
15 of 19 checks passed
@PureWeen PureWeen deleted the fix-28800 branch July 1, 2025 16:18
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-templates Project templates, Item Templates for Blazor and MAUI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove .NET 8 specific code from sample content template
3 participants