Skip to content

[Testing] Disabling the Essentials Geocoding failing tests on Windows #30508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

[Testing] Disabling the Essentials Geocoding failing tests on Windows #30508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Essentials/test/DeviceTests/Tests/Geocoding_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ public Geocoding_Tests()
ApplicationModel.Platform.MapServiceToken = "RJHqIE53Onrqons5CNOx~FrDr3XhjDTyEXEjng-CRoA~Aj69MhNManYUKxo6QcwZ0wmXBtyva0zwuHB04rFYAPf7qqGJ5cHb03RCDw1jIW8l";
#endif
}
#if !ANDROID

// Temporarily disabling this test on Windows due to consistent CI failures.
// See https://github.com/dotnet/maui/issues/30507 for tracking re-enablement.
#if !ANDROID && !WINDOWS
[Theory]
Comment on lines +21 to 22
Copy link
Preview

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using xUnit’s Skip parameter on the [Theory] attribute to skip the test on Windows rather than a compile-time directive. For example:

[Theory(Skip = "Temporarily disabled on Windows: https://github.com//issues/30507")]

Suggested change
#if !ANDROID && !WINDOWS
[Theory]
[Theory(Skip = "Temporarily disabled on Windows: https://github.com/dotnet/maui/issues/30507")]

Copilot uses AI. Check for mistakes.

[InlineData(47.673988, -122.121513)]
public async Task Get_Placemarks_LatLong(double latitude, double longitude)
Expand Down
Loading