Skip to content

[release/10.0.1xx-preview6] Update pipelines for release #30511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 9, 2025

Description of Change

Update release branch with some commits for pipelines

rmarinho added 4 commits July 9, 2025 12:35
* [ai] Remove github mcp

* [ci] Use certs/profile azdo task

* Fix

* again

* try again

* Access passworkd

* again

* legacy

* needs to work like this

* try again

* try just mauiu-provisionator

* [ci] clean

* We need this as variable group from key vault doesn t work

* Add comments

* Try to always run on devdiv

* fix

* remove legacy

* Maybe try fix on Azure pipelines hosts

* Fix variable

* Add continueOnError: true

* Remove old provisioning
# Conflicts:
#	eng/pipelines/common/provision.yml
#	eng/pipelines/common/variables.yml
* [ci] Use new maui release variabel group

[ci] Remove maui-secrets

Don t reboot devices

[ci] remove extra pat and format

Use new variable

[ci] Move back to the old pat name

Add provisionator variable group

update provisionator token

Remove extra variable

try again

Fix override oon steps of github token

add variable for uri

More fixes

We just need the pat for maui release

* UseProvisionator

* needs to be used on xamarin public
# Conflicts:
#	eng/pipelines/common/provision.yml
#	eng/pipelines/common/variables.yml
#	eng/pipelines/handlers.yml
@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 11:41
@rmarinho rmarinho requested a review from a team as a code owner July 9, 2025 11:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release/10.0.1xx-preview6 branch to migrate pipeline provisioning, signing, and variable handling to new patterns and tidy configuration.

  • Remove legacy macOS provisioning script and code-signing calls.
  • Refactor common provisioning steps to use InstallAppleCertificate/InstallAppleProvisioningProfile tasks and secure files.
  • Update variable groups and inline/token references; condense multiline conditions for brevity.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/provisioning/provisioning.csx Removed legacy AppleCodesignIdentity/Profile calls
eng/pipelines/common/provision.yml Switched to InstallAppleCertificate / InstallAppleProvisioningProfile tasks
eng/pipelines/common/variables.yml Replaced Xamarin-Secrets group with maui-provisionator and MAUI groups
eng/pipelines/ui-tests.yml Updated variables template reference and removed gitHubToken line
eng/pipelines/device-tests.yml Updated variables template reference and commented out token use
eng/pipelines/handlers.yml Inlined multi-line conditions
eng/pipelines/maui-release.yml Adjusted conditional indentation for private-server signing
Comments suppressed due to low confidence (4)

eng/pipelines/common/provision.yml:90

  • The conditional block is missing a leading dash '-' and proper indentation, so it won't be treated as a YAML list item. Add '- ' before the condition and align child steps under it to ensure the block is applied correctly.
- ${{ if or(eq(variables['System.TeamProject'], 'DevDiv'), ne(parameters.skipProvisionator, true)) }}:

eng/pipelines/maui-release.yml:171

  • This comment and the following template step are no longer nested under the if condition due to indentation changes. Re-indent both the comment and the - template: ... line under the conditional to preserve the intended grouping.
      # Sign only using the private server   

eng/pipelines/handlers.yml:160

  • [nitpick] Inlining this complex condition reduces readability. Consider reverting to a multi-line, indented format to make the logical branches clearer for future maintenance.
        condition: or( ${{ parameters.BuildEverything }}, ne(variables['Build.Reason'], 'PullRequest'), eq('${{ BuildConfiguration }}', 'Release'))

eng/pipelines/common/variables.yml:54

  • The comment indicates these variable groups should apply to all builds, but the condition explicitly excludes 'dotnet-maui'. Either broaden the condition to include all non-PR builds or update the comment to reflect the exclusion.
- ${{ if and(ne(variables['Build.DefinitionName'], 'maui-pr'), ne(variables['Build.DefinitionName'], 'dotnet-maui')) }}:

@rmarinho
Copy link
Member Author

rmarinho commented Jul 9, 2025

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@rmarinho rmarinho merged commit 8b9af73 into release/10.0.1xx-preview6 Jul 9, 2025
5 of 7 checks passed
@rmarinho rmarinho deleted the update-pipelines-release branch July 9, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant