[release/10.0.1xx-preview6] Update pipelines for release #30511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ai] Remove github mcp * [ci] Use certs/profile azdo task * Fix * again * try again * Access passworkd * again * legacy * needs to work like this * try again * try just mauiu-provisionator * [ci] clean * We need this as variable group from key vault doesn t work * Add comments * Try to always run on devdiv * fix * remove legacy * Maybe try fix on Azure pipelines hosts * Fix variable * Add continueOnError: true * Remove old provisioning # Conflicts: # eng/pipelines/common/provision.yml # eng/pipelines/common/variables.yml
* [ci] Use new maui release variabel group [ci] Remove maui-secrets Don t reboot devices [ci] remove extra pat and format Use new variable [ci] Move back to the old pat name Add provisionator variable group update provisionator token Remove extra variable try again Fix override oon steps of github token add variable for uri More fixes We just need the pat for maui release * UseProvisionator * needs to be used on xamarin public # Conflicts: # eng/pipelines/common/provision.yml # eng/pipelines/common/variables.yml # eng/pipelines/handlers.yml
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release/10.0.1xx-preview6 branch to migrate pipeline provisioning, signing, and variable handling to new patterns and tidy configuration.
- Remove legacy macOS provisioning script and code-signing calls.
- Refactor common provisioning steps to use InstallAppleCertificate/InstallAppleProvisioningProfile tasks and secure files.
- Update variable groups and inline/token references; condense multiline conditions for brevity.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/provisioning/provisioning.csx | Removed legacy AppleCodesignIdentity/Profile calls |
| eng/pipelines/common/provision.yml | Switched to InstallAppleCertificate / InstallAppleProvisioningProfile tasks |
| eng/pipelines/common/variables.yml | Replaced Xamarin-Secrets group with maui-provisionator and MAUI groups |
| eng/pipelines/ui-tests.yml | Updated variables template reference and removed gitHubToken line |
| eng/pipelines/device-tests.yml | Updated variables template reference and commented out token use |
| eng/pipelines/handlers.yml | Inlined multi-line conditions |
| eng/pipelines/maui-release.yml | Adjusted conditional indentation for private-server signing |
Comments suppressed due to low confidence (4)
eng/pipelines/common/provision.yml:90
- The conditional block is missing a leading dash '-' and proper indentation, so it won't be treated as a YAML list item. Add '- ' before the condition and align child steps under it to ensure the block is applied correctly.
- ${{ if or(eq(variables['System.TeamProject'], 'DevDiv'), ne(parameters.skipProvisionator, true)) }}:
eng/pipelines/maui-release.yml:171
- This comment and the following template step are no longer nested under the if condition due to indentation changes. Re-indent both the comment and the
- template: ...line under the conditional to preserve the intended grouping.
# Sign only using the private server
eng/pipelines/handlers.yml:160
- [nitpick] Inlining this complex condition reduces readability. Consider reverting to a multi-line, indented format to make the logical branches clearer for future maintenance.
condition: or( ${{ parameters.BuildEverything }}, ne(variables['Build.Reason'], 'PullRequest'), eq('${{ BuildConfiguration }}', 'Release'))
eng/pipelines/common/variables.yml:54
- The comment indicates these variable groups should apply to all builds, but the condition explicitly excludes 'dotnet-maui'. Either broaden the condition to include all non-PR builds or update the comment to reflect the exclusion.
- ${{ if and(ne(variables['Build.DefinitionName'], 'maui-pr'), ne(variables['Build.DefinitionName'], 'dotnet-maui')) }}:
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update release branch with some commits for pipelines