Skip to content

Merge Candidate into SR9 if it's stable enough #30523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 9, 2025

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jul 9, 2025

Description

The candidate branch should be ready

If this PR passes all tests then let's merge it in for the SR9 release

github-actions bot and others added 23 commits July 8, 2025 17:37
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* added test cases

* modified test cases

* added snapshots

* added mac and windows snapshots
* Added ImageButton Feature tests

* Changes updated

* Modified tests

* Added Images

* Modified image

* Added images

---------

Co-authored-by: Shane Neuville <[email protected]>
…dows (#29966)

* Update WebViewHelpers.Windows.cs

* Update WebViewHelpers.Windows.cs

* Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
…l image, even when disposeOriginal is set to true (#29936)

* Fix for original image disposal when disposeOriginal is true in Resize and Downsize methods on Android and iOS

* Updated the fix for iOS, and modified the test case to reflect the changes

* Updated the issue link in test case
* Added Label Feature Tests

* Changes updated

* Added properties for Image control

* Added Images

* changes updated

* Added images

* changes updated

* Added images

---------

Co-authored-by: Shane Neuville <[email protected]>
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
…er switching activities (#28767)

* Fixing issue #24357 by removing outdated menu items as Android can delete them after switching activities

* Disposing outdated IMenuItem just in case

* Reduced memory allocation

* Tuned performance a bit
…s into device tests - 6 (#28399)

* Enabled the translation property for device tests

* Added the helper method

* Reverted the changes

* Updated EditorTests.Android.cs

* Fix formating
…m the navigation stack (#30049)

* Update NavigationProxy.cs

* test case added

* Update Issue29923.cs

* fix updated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…eration Disabled (#28934)

* Update WebViewHandler.Android.cs

* Test case added

* Update WebView.cs

* fix updated

* Update WebView.cs

* Create ControlsShouldRemainVisibleWithWebViewWhenHardwareAccelerationIsDisabled.png

* updated test case codes

* Update ControlsShouldRemainVisibleWithWebViewWhenHardwareAccelerationIsDisabled.png

* Update Issue28798.cs

* Update ControlsShouldRemainVisibleWithWebViewWhenHardwareAccelerationIsDisabled.png

updated google with example.com as google logo keeps changing.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* added Feature Matrix for Entry Control

* added a test cases for EntryControl

* added a test cases for entry feature matrix

* updated changes

* updated changes

* modified changes

* updated

* updated changes

* added snapshots

* added snapshot

* updated changes

* modified snapshots

* updated changes

* Updated snaps and added event features

* Added tests

* Added snapshots

* modified changes

* added modified snapshots

* Added changed snapshot

* updated changes

* modified test case

* Added snapshot

* added snapshots for windows

* Added snapshots

* Added snapshot from CI

---------

Co-authored-by: Anandhan Rajagopal <[email protected]>
Co-authored-by: Shane Neuville <[email protected]>
* added test cases

* added new test cases

* added new test cases

* added android and iOS snapshots

* modified test case and added snapshots

* added failing condition
* Skip useless initial handler mappings calls

* Apply suggestions from code review, fixes check on Maximum*

* Windows: automation properties are extremely costly

* Fix broken UI tests

* Workaround Windows broken tests

---------

Co-authored-by: MartyIX <[email protected]>
… DeviceInfo (#30288)

* Initial plan

* Fix OnIdiom threading issue by removing using statements in DeviceInfo.android.cs

Co-authored-by: PureWeen <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: PureWeen <[email protected]>
…rking with CV2 (#27056)

* Fixed the ItemSpacing issue in CV2

* reenabled the test

* changed the fix based on conflicts file

* Optimized the fix in the LayoutFactory2
* updated changes

* modified changes

* added snapshot
…te (#30413)

* Added test_fails and issue link

* updated
@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 17:08
@PureWeen PureWeen requested a review from a team as a code owner July 9, 2025 17:08
@PureWeen PureWeen requested review from jfversluis and mattleibow July 9, 2025 17:08
@PureWeen
Copy link
Member Author

PureWeen commented Jul 9, 2025

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Merges the candidate branch into the SR9 release by adding new UI tests for issue regressions and expanding the feature-matrix test suite with accompanying HostApp pages.

  • Adds Shared.Tests UI tests for issues 29923, 29086, 28798, and 21886
  • Introduces new feature‐matrix test classes for Switch, ProgressBar, Image, ImageButton, and Entry
  • Implements corresponding HostApp pages (XAML + code‐behind) for both issue reproductions and feature controls

Reviewed Changes

Copilot reviewed 54 out of 449 changed files in this pull request and generated no comments.

File Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue*.cs New issue-focused UI tests
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/*.cs Expanded feature-matrix test suites
src/Controls/tests/TestCases.HostApp/Issues/*.xaml(.cs) HostApp pages for issue repro scenarios
src/Controls/tests/TestCases.HostApp/FeatureMatrix/* HostApp pages driving feature-matrix controls
Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.HostApp/FeatureMatrix/ProgressBar/ProgressBarControlPage.xaml:73

  • The x:Name and AutomationId/content are inconsistent for this radio button. Rename the x:Name to "IsVisibleFalseRadio" or swap it with the true radio to match its Content="False" and AutomationId.
                           x:Name="IsVisibleTrueRadio"

src/Controls/tests/TestCases.HostApp/FeatureMatrix/ProgressBar/ProgressBarControlPage.xaml:131

  • The x:Name "ShadowFalseRadio" conflicts with Content="True" and AutomationId="ShadowTrueRadio". Rename it to "ShadowTrueRadio" to match the intended purpose.
                           x:Name="ShadowFalseRadio"

@PureWeen PureWeen merged commit 932eb5f into release/9.0.1xx-sr9 Jul 9, 2025
8 checks passed
@PureWeen PureWeen deleted the maybe_candidate_into_sr9_no_promises branch July 9, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.