-
Notifications
You must be signed in to change notification settings - Fork 327
FV changes #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FV changes #1177
Conversation
Hi @mansijain52, are you still working on this? |
Yes. We are done with changes. Waiting to get this merged |
@dotnet-policy-service agree company="Microsoft" |
/AzurePipelines run |
Pull request contains merge conflicts. |
Thanks for confirming! Let wait for #1197 |
Hi @mansijain52, please resolve your conflicts and proceed with this PR, thanks! |
Hi @mansijain52, will you continue work on this? |
Yes. I will complete it this week
…On Wed, 26 Feb, 2025, 09:50 Dan Wu, ***@***.***> wrote:
Hi @mansijain52 <https://github.com/mansijain52>, will you continue work
on this?
—
Reply to this email directly, view it on GitHub
<#1177 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRCDNQZJ4RDR6UMNHEEYG32RU6IXAVCNFSM6AAAAABIYAAKA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBTHA2TKOBTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: wudanzy]*wudanzy* left a comment (dotnet/spark#1177)
<#1177 (comment)>
Hi @mansijain52 <https://github.com/mansijain52>, will you continue work
on this?
—
Reply to this email directly, view it on GitHub
<#1177 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRCDNQZJ4RDR6UMNHEEYG32RU6IXAVCNFSM6AAAAABIYAAKA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBTHA2TKOBTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ready for review |
/AzurePipelines run |
Thanks for the change! |
Azure Pipelines successfully started running 1 pipeline(s). |
src\csharp\Microsoft.Spark\TaskContext.cs#L28 src\csharp\Microsoft.Spark\TaskContext.cs(28,22): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'TaskContext' already contains a definition for 'CPUs' |
Maybe a conflict, because previous upgrades (3.3, 3.5) already added this field. |
Updated |
@wudanzy @SparkSnail Pending review! |
Commenter does not have sufficient privileges for PR 1177 in repo dotnet/spark |
Hi @mansijain52, the spark 3.4 was already added and a new release was made. Please check if that already meets your need. |
Supported spark 3.4
Added scala code for spark 3.4
Made changes to it compatible for spark 3.4
Changes to support c# in latest synapse runtime
Renamed DotnetRunner class to Runner and its references.
This change is mainly needed for using dotnet for spark library in Synapse latest runtime. As we observed that SYnapse has a check at their end to look for this keyword and block the execution.
With this,we are able to run dotnet job in Synapse latest runtime using custom spark worker library