Skip to content

FV changes #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

mansijain52
Copy link

@mansijain52 mansijain52 commented Jun 4, 2024

  • Supported spark 3.4
    Added scala code for spark 3.4
    Made changes to it compatible for spark 3.4

  • Changes to support c# in latest synapse runtime
    Renamed DotnetRunner class to Runner and its references.
    This change is mainly needed for using dotnet for spark library in Synapse latest runtime. As we observed that SYnapse has a check at their end to look for this keyword and block the execution.
    With this,we are able to run dotnet job in Synapse latest runtime using custom spark worker library

@wudanzy
Copy link
Collaborator

wudanzy commented Dec 19, 2024

Hi @mansijain52, are you still working on this?

@mansijain52
Copy link
Author

Hi @mansijain52, are you still working on this?

Yes. We are done with changes. Waiting to get this merged

@mansijain52
Copy link
Author

@mansijain52 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Microsoft"

@mansijain52 mansijain52 marked this pull request as ready for review January 7, 2025 09:08
@mansijain52 mansijain52 marked this pull request as draft January 7, 2025 09:10
@wudanzy
Copy link
Collaborator

wudanzy commented Jan 7, 2025

/AzurePipelines run

Copy link

Pull request contains merge conflicts.

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 7, 2025

Thanks for confirming! Let wait for #1197

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 14, 2025

Hi @mansijain52, please resolve your conflicts and proceed with this PR, thanks!

@wudanzy
Copy link
Collaborator

wudanzy commented Feb 26, 2025

Hi @mansijain52, will you continue work on this?

@mansijain52
Copy link
Author

mansijain52 commented Feb 26, 2025 via email

@mansijain52 mansijain52 marked this pull request as ready for review March 1, 2025 06:48
@mansijain52
Copy link
Author

Hi @mansijain52, will you continue work on this?

Ready for review

@wudanzy
Copy link
Collaborator

wudanzy commented Mar 2, 2025

/AzurePipelines run

@wudanzy
Copy link
Collaborator

wudanzy commented Mar 2, 2025

Thanks for the change!

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wudanzy
Copy link
Collaborator

wudanzy commented Mar 6, 2025

src\csharp\Microsoft.Spark\TaskContext.cs#L28

src\csharp\Microsoft.Spark\TaskContext.cs(28,22): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'TaskContext' already contains a definition for 'CPUs'

@wudanzy
Copy link
Collaborator

wudanzy commented Mar 6, 2025

Maybe a conflict, because previous upgrades (3.3, 3.5) already added this field.

@mansijain52
Copy link
Author

Maybe a conflict, because previous upgrades (3.3, 3.5) already added this field.

Updated

@mansijain52 mansijain52 closed this Apr 2, 2025
@mansijain52 mansijain52 reopened this Apr 2, 2025
@mansijain52
Copy link
Author

@wudanzy @SparkSnail Pending review!

@mansijain52 mansijain52 removed their assignment Apr 7, 2025
Copy link

Commenter does not have sufficient privileges for PR 1177 in repo dotnet/spark

@wudanzy
Copy link
Collaborator

wudanzy commented May 15, 2025

Hi @mansijain52, the spark 3.4 was already added and a new release was made. Please check if that already meets your need.

@wudanzy wudanzy closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants