Add support for the host being an IP address. #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lulf Would you be fine, with me adding an extra function to specify an endpoint manually? I agree, that having proper IPv6 handing for URLs is useful for generic applications, but for applications that exclusively use manually specified endpoints, it seems a little wasteful to first format a URL, just for it to be immediately deserialized again. |
|
I just noticed, that I messed up with nourl and defmt support. |
|
It's fixed now. |
|
I've temporarily pointed embedded-tls to git, since that resolves an issue, which caused errors with TLS. Once the relevant PR gets merged and a new version released, I'll point this back to crates.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as discussed in #116 this PR adds support for the URL host to be an IP address. When the PR for
nourlis merged, I'll pointnourlback to crates.io and mark this as ready for review.I also added a check to skip the DNS lookup all together, if the host is an IP address, which should provide better performance, than going through a mock DNS resolver first.
Greetings
Simon