This repository was archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Go list implementation for detecting dependencies #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lseppala
commented
May 14, 2022
6ead0b9
to
75bea64
Compare
75bea64
to
eedb5d7
Compare
a4fe75d
to
0a2f424
Compare
mrysav
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
go mod graph
implementation with an implementation based ongo list
, which was suggested here.This is more accurate than
go mod graph
because:However, this does not capture transitive dependency relationships. In order to capture transitive dependency relationships, we need to run both
go list
andgo mod graph
. However, the operating model of the toolkit library currently limits us to one command per snapshot. The toolkit library will need to be updated to allow for more flexibility before we run both commands.This work also adds a simple Go project to demonstrate the Action within this repo itself.
Example run of Action: https://github.com/dsp-testing/go-snapshot-action/actions/runs/2374558077