Skip to content
This repository was archived by the owner on Jun 16, 2022. It is now read-only.

Upgrade to use updated dependency-submission-toolkit #6

Merged
merged 6 commits into from
Jun 10, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"env": {
"browser": true,
"es2021": true
"es2021": true,
"jest/globals": true
},
"extends": [
"standard"
Expand All @@ -12,7 +13,8 @@
"sourceType": "module"
},
"plugins": [
"@typescript-eslint"
"@typescript-eslint",
"jest"
],
"rules": {
}
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/go-action.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Go Action detection of dependencies
on:
push:
branches:
- main
push

jobs:
go-action-detection:
runs-on: ubuntu-latest
Expand All @@ -16,4 +15,4 @@ jobs:
uses: dsp-testing/go-snapshot-action@lsep/go-list-impl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I knew it was too good to be true that it worked on the first run 🤦

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! But it did work! 🎉 https://github.com/dsp-testing/go-snapshot-action/runs/6836365970?check_suite_focus=true

Updating to point to main, which it will run once merged

with:
go-mod-path: go-example/go.mod
go-build-target: go-example/cmd/octocat.go
go-build-target: go-example/cmd/octocat.go
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- run: |
npm install
npm ci
env:
NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
- run: |
Expand Down
1 change: 0 additions & 1 deletion .npmrc

This file was deleted.

7 changes: 7 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"semi": false,
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "none",
"useTabs": false
}
12 changes: 0 additions & 12 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,6 @@ inputs:
description: "GitHub Personal Access Token (PAT). Defaults to PAT provided by Action runner"
required: false
default: ${{ github.token }}
detector-name:
required: false
description: 'Name of the detector running the go action e.g. Go Snapshot Detector'
default: 'Go Snapshot Action'
detector-url:
required: false
description: 'URL of the detector running the go action e.g. http://github.com/dsp-testing/go-snapshot-action'
default: 'http://github.com/dsp-testing/go-snapshot-action'
detector-version:
required: false
description: 'Version of the detector running the go action e.g. 0.0.1'
default: '0.0.1'
metadata:
required: false
description: 'User provided map of max key/value pairs of metadata to include with the snapshot e.g. {"lastModified": "12-31-2022"}'
Expand Down
Loading