Skip to content

added support for multiple dictionaries #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zippoxer
Copy link

Hi,

Following your comment on Reddit, this is my attempt at making a pull request with the changes I've made at zippoxer/petname.

This pull request adds support for multiple dictionaries by introducing the Dict interface, which is implemented by packages under the dict folder.

The usage of the Generate method has also changed, and it now takes a Dict as it's first argument:

petname.Generate(dict.Small, 2, "-")

I should note that this pull request might break some of the scripts under the debian folder, since I didn't yet take a close look in there.

I'm taking the old repository (zippoxer/petname) down, as this fork provides the same functionality. I hope this would make things right between us.

Cheers :-)

@dustinkirkland
Copy link
Owner

Cool, thanks for submitting this. I'm still reviewing it. I see that, basically, you want the same support in the golang-petname package, for small/medium/large wordlists, that we already have in the master "petname" shell implementation. I'm working on merging your pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants