Use shallow copy for ranked dicts when user_inputs are present in omnimatch #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbsurdlySuspicious
force-pushed
the
feature/user_inputs_copy
branch
from
af1d4b2 to
98d87ec
Compare
AbsurdlySuspicious
force-pushed
the
feature/user_inputs_copy
branch
from
98d87ec to
c4951d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #84
Use shallow dict copy for
_ranked_dictionarieswhen user inputs are present.Should prevent possible issues with thread safety.
Performance impact should be minimal since there's not a lot of keys in root dictionary (less than 10 dictionaries by default)