-
-
Notifications
You must be signed in to change notification settings - Fork 190
Simplify startup code #5701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Simplify startup code #5701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc of all things is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing 🤩
Could you walk us through the changes tonight?
The open questions I have
|
I tried to simplify the startup of appbundler by removing these xml files
|
Only reported by Linux build ....
|
exist-start/src/main/java/org/exist/start/classloader/Classpath.java
Outdated
Show resolved
Hide resolved
"Found match: " + actualFileName | ||
+ " for jar file pattern: " + filename | ||
); | ||
System.err.println("Found match: " + actualFileName + " for jar file pattern: " + filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG.error() can now be used
IncompatibleJavaVersion(13), | ||
IncompatibleJavaVersion(14), | ||
IncompatibleJavaVersion(15, 0, 2) | ||
create(12), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to compile start.jar with java21 iso java8 .... these items could be removed; voiding all tests too,
The original idea was to remove all old Jetty code.
The PR evolved into a significant rewrite refactoring and cleanup of the original code; Move methods to locations where used, combine functionality in a new Class, split-up the "doIt" method, with readable methods.