Skip to content

Simplify startup code #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Conversation

dizzzz
Copy link
Member

@dizzzz dizzzz commented Apr 13, 2025

The original idea was to remove all old Jetty code.

The PR evolved into a significant rewrite refactoring and cleanup of the original code; Move methods to locations where used, combine functionality in a new Class, split-up the "doIt" method, with readable methods.

@dizzzz dizzzz requested a review from a team as a code owner April 13, 2025 21:45
@dizzzz dizzzz marked this pull request as draft April 13, 2025 21:47
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc of all things is failing

Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing 🤩
Could you walk us through the changes tonight?

@dizzzz
Copy link
Member Author

dizzzz commented Apr 14, 2025

The open questions I have

  • shall I make this module start.jar compatible with Java8 ?
    • pro: decent handling of old java versions, with good error message
    • con: bin/startup.sh contains parameters that will stop java8 anyway.
  • start.jar has no external dependencies
  • OK to remove all all old jetty-codebase references?
    • all has been removed/refactored and is eXist-db specific

@dizzzz
Copy link
Member Author

dizzzz commented Apr 14, 2025

I tried to simplify the startup of appbundler by removing these xml files

  • (old) maven plugin crashes with NPE, cant find reason, is under documented
    • great work of Adam understanding the plugin config
  • idea is to create a (python)script/java module that can update the appbundler xml files
    • this enables updating/changing jar files after release

Only reported by Linux build ....
@duncdrum
Copy link
Contributor

@dizzzz

  • I don't see much of a point in J8 in this instance, it ll will error one way or the other
  • My guess for relevance of 0 deps would be yes, but @wolfgangmm knows more
  • uhmm yes please, its a new dawn ;-)

@dizzzz dizzzz requested a review from reinhapa April 15, 2025 19:48
"Found match: " + actualFileName
+ " for jar file pattern: " + filename
);
System.err.println("Found match: " + actualFileName + " for jar file pattern: " + filename);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOG.error() can now be used

IncompatibleJavaVersion(13),
IncompatibleJavaVersion(14),
IncompatibleJavaVersion(15, 0, 2)
create(12),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to compile start.jar with java21 iso java8 .... these items could be removed; voiding all tests too,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants