Skip to content

Align DOM implementations with org.w3c.dom #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Align DOM implementations with org.w3c.dom #5740

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4b0f8f
[fix] in memory DOM implementation getAttribute nonnull
line-o May 13, 2025
63513d9
[refactor] dom.peristent.ElementImpl
line-o May 13, 2025
9884a87
[refactor] Lucene module
line-o May 13, 2025
55a4692
[refactor] remove commons-lang3 dependency from last extensions
line-o May 13, 2025
4b0efd8
[refactor] remove commons-lang3 dependency from 2 core classes
line-o May 13, 2025
3596982
[refactor] replace ArrayUtils.contains with Set.contains in FunBaseURI
line-o May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[refactor] remove commons-lang3 dependency from 2 core classes 
- Eval.java and AppRestoreUtils
  • Loading branch information
@line-o
line-o committed May 14, 2025
commit 4b0efd81fb635eca88daeb7c655c23b6181cd530
3 changes: 1 addition & 2 deletions exist-core/src/main/java/org/exist/backup/restore/AppRestoreUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
*/
package org.exist.backup.restore;

import org.apache.commons.lang3.StringUtils;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.exist.Namespaces;
Expand Down Expand Up @@ -141,7 +140,7 @@ public void startElement(String uri, String localName, String qName, Attributes
if (PKG_NAMESPACE.equals(uri) && "package".equals(localName)) {
final String version = attributes.getValue("version");
final String name = attributes.getValue("name");
if (StringUtils.isEmpty(version) || StringUtils.isEmpty(name)) {
if (version.isEmpty() || name.isEmpty()) {
LOG.warn("Invalid package descriptor for {}", app.getSymbolicPath());
return;
}
Expand Down
1 change: 0 additions & 1 deletion exist-core/src/main/java/org/exist/xquery/functions/util/Eval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
import org.xml.sax.XMLReader;

import static java.nio.charset.StandardCharsets.UTF_8;
import static org.apache.commons.lang3.StringUtils.isNotEmpty;
import static org.exist.xquery.FunctionDSL.*;
import static org.exist.xquery.functions.util.UtilModule.functionSignatures;

Expand Down