Skip to content

Adds comments to .properties files to not change port when using in docker container #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds comments to .properties files to not change port when using in docker container #637

wants to merge 1 commit into from

Conversation

moumenakkad
Copy link

@moumenakkad moumenakkad commented Feb 18, 2025 •
edited by aaronzi
Loading

All .properties files were modified. A comment was added to ensure user is warned about changing port while docker is running, as specified in rules of issue #411

Closes #411

@aaronzi aaronzi changed the title Fix issue 411 Adds comments to .properties files to not change port when using in docker container Feb 20, 2025
aaronzi
aaronzi requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments of the .properties files. Just a minor remark/question: What do you mean by "The port should only by changed when the application is not running"? I think this last sentence could say something like: "This port should only be changed when running the application without Docker".

aaronzi
aaronzi requested changes Feb 20, 2025
View reviewed changes
aaronzi
aaronzi requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also merge origin/main from the remote repository into your branches. There were recent changes in the main branch that will require minimal adaptions in your PR

basyx.aasregistry/basyx.aasregistry-feature-authorization/src/test/resources/application.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change. This is in a test

basyx.aasregistry/basyx.aasregistry-feature-hierarchy-example/docker-compose.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be removed since this is not an application settings file but a docker-compose file. Here the external port can actually be changed

basyx.aasregistry/docker-compose/docker-compose.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Please remove

basyx.submodelregistry/basyx.submodelregistry-feature-hierarchy-example/docker-compose.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

basyx.submodelregistry/docker-compose/docker-compose.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

examples/BaSyxOperationDelegation/basyx/aas-env.properties Outdated
Comment on lines 1 to 3
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.

examples/BaSyxOperationDelegation/docker-compose.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

...s/BaSyxOperationDelegation/exampleOperationService/src/main/resources/application.properties Outdated
Comment on lines 1 to 3
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.

examples/BaSyxSecured/basyx/aas-discovery.properties Outdated
Comment on lines 1 to 3
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.

examples/BaSyxSecured/basyx/aas-env.properties Outdated
Comment on lines 1 to 3
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.
# This port should only be changed when running the application without Docker
# Do NOT change any port while running in a Docker container.
# Changing this will make the service unreachable from outside the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronzi aaronzi aaronzi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comments to .properties files to not change port config when using with docker
2 participants
@moumenakkad @aaronzi