Skip to content

Updated elgohr/Publish-Docker-Github-Action to a supported version (v5) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 268 commits into
base: master
Choose a base branch
from

Conversation

elgohr
Copy link

@elgohr elgohr commented Mar 29, 2023

elgohr/Publish-Docker-Github-Action@master is not supported anymore

kartikp10 and others added 30 commits August 4, 2021 16:37
…io#1468)

* Use md5 hash of source for windows folder name

* Remove unused import

* Ignore Bandit for md5 usage for folder name
…io#1468)

* Use md5 hash of source for windows folder name

* Remove unused import

* Ignore Bandit for md5 usage for folder name
…io#1468)

* Use md5 hash of source for windows folder name

* Remove unused import

* Ignore Bandit for md5 usage for folder name
…io#1468)

* Use md5 hash of source for windows folder name

* Remove unused import

* Ignore Bandit for md5 usage for folder name
…io#1468)

* Use md5 hash of source for windows folder name

* Remove unused import

* Ignore Bandit for md5 usage for folder name
…io#1468)

* Use md5 hash of source for windows folder name

* Remove unused import

* Ignore Bandit for md5 usage for folder name
mikeurbanski1 and others added 29 commits August 17, 2021 23:10
Added PunkSecurity from the UK
Added PunkSecurity from the UK
Added PunkSecurity from the UK
…missing

CFN Graph creation crashes due to DependsOn resource missing
…missing

CFN Graph creation crashes due to DependsOn resource missing
…missing

CFN Graph creation crashes due to DependsOn resource missing
* check if attribute contains value only if it is iterable

* stringify portRange in arm check NSGRulePortAccessRestricted
* check if attribute contains value only if it is iterable

* stringify portRange in arm check NSGRulePortAccessRestricted
* check if attribute contains value only if it is iterable

* stringify portRange in arm check NSGRulePortAccessRestricted
* check if attribute contains value only if it is iterable

* stringify portRange in arm check NSGRulePortAccessRestricted
* check if attribute contains value only if it is iterable

* stringify portRange in arm check NSGRulePortAccessRestricted
* check if attribute contains value only if it is iterable

* stringify portRange in arm check NSGRulePortAccessRestricted
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 29, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 23.34 😞 22.85 😞 -0.49 👍
Method Length 84.74 🙂 87.51 🙂 2.77 👎
Working memory 9.51 🙂 9.45 🙂 -0.06 👍
Quality 56.42% 🙂 56.39% 🙂 -0.03% 👎
Other metrics Before After Change
Lines 4138 4465 327
Changed files Quality Before Quality After Quality Change
setup.py 59.60% 🙂 59.53% 🙂 -0.07% 👎
checkov/version.py 100.00% ⭐ 100.00% ⭐ 0.00%
checkov/arm/runner.py 4.32% ⛔ 4.31% ⛔ -0.01% 👎
checkov/arm/checks/resource/NSGRulePortAccessRestricted.py 37.29% 😞 37.24% 😞 -0.05% 👎
checkov/cloudformation/cfn_utils.py 51.59% 🙂 51.35% 🙂 -0.24% 👎
checkov/cloudformation/context_parser.py 66.02% 🙂 65.75% 🙂 -0.27% 👎
checkov/cloudformation/graph_manager.py 71.43% 🙂 69.08% 🙂 -2.35% 👎
checkov/cloudformation/runner.py 43.16% 😞 39.82% 😞 -3.34% 👎
checkov/cloudformation/checks/resource/BaseCloudsplainingIAMCheck.py 48.63% 😞 50.07% 🙂 1.44% 👍
checkov/cloudformation/checks/resource/base_resource_value_check.py 63.21% 🙂 64.89% 🙂 1.68% 👍
checkov/cloudformation/checks/resource/aws/ECSClusterContainerInsights.py 75.32% ⭐ 76.35% ⭐ 1.03% 👍
checkov/cloudformation/checks/resource/aws/IAMRoleAllowAssumeFromAccount.py 31.50% 😞 58.79% 🙂 27.29% 👍
checkov/cloudformation/graph_builder/graph_to_definitions.py 66.61% 🙂 58.68% 🙂 -7.93% 👎
checkov/cloudformation/graph_builder/local_graph.py 69.65% 🙂 66.18% 🙂 -3.47% 👎
checkov/cloudformation/graph_builder/graph_components/block_types.py 80.79% ⭐ 87.65% ⭐ 6.86% 👍
checkov/cloudformation/parser/__init__.py 47.68% 😞 38.52% 😞 -9.16% 👎
checkov/common/bridgecrew/bc_source.py 93.40% ⭐ 92.41% ⭐ -0.99% 👎
checkov/common/bridgecrew/platform_integration.py 64.84% 🙂 63.40% 🙂 -1.44% 👎
checkov/common/bridgecrew/integration_features/features/suppressions_integration.py 67.40% 🙂 67.97% 🙂 0.57% 👍
checkov/common/checks_infra/solvers/attribute_solvers/contains_attribute_solver.py 80.26% ⭐ 75.64% ⭐ -4.62% 👎
checkov/common/checks_infra/solvers/filter_solvers/within_filter_solver.py 94.02% ⭐ 92.81% ⭐ -1.21% 👎
checkov/common/goget/github/get_git.py 78.13% ⭐ 78.46% ⭐ 0.33% 👍
checkov/common/graph/checks_infra/registry.py 86.25% ⭐ 84.88% ⭐ -1.37% 👎
checkov/common/graph/graph_builder/graph_components/edge.py 89.43% ⭐ 93.52% ⭐ 4.09% 👍
checkov/common/output/graph_record.py 85.31% ⭐ 84.55% ⭐ -0.76% 👎
checkov/common/util/docs_generator.py 46.96% 😞 41.86% 😞 -5.10% 👎
checkov/kubernetes/runner.py 19.84% ⛔ 20.17% ⛔ 0.33% 👍
checkov/terraform/checks/resource/aws/CodeBuildProjectEncryption.py 79.58% ⭐ 75.95% ⭐ -3.63% 👎
checkov/terraform/graph_builder/local_graph.py 57.89% 🙂 59.46% 🙂 1.57% 👍
checkov/terraform/module_loading/registry.py 50.45% 🙂 46.47% 😞 -3.98% 👎
checkov/terraform/module_loading/loaders/git_loader.py 79.84% ⭐ 83.87% ⭐ 4.03% 👍
checkov/terraform/variable_rendering/renderer.py 46.07% 😞 45.96% 😞 -0.11% 👎
integration_tests/test_checkov_cli_integration_report.py 92.47% ⭐ 86.75% ⭐ -5.72% 👎
tests/cloudformation/test_graph_manager.py 65.70% 🙂 62.75% 🙂 -2.95% 👎
tests/cloudformation/graph/graph_builder/test_local_graph.py 69.18% 🙂 64.88% 🙂 -4.30% 👎
tests/cloudformation/runner/test_runner.py 66.44% 🙂 66.43% 🙂 -0.01% 👎
tests/cloudformation/utils/test_cfn_utils.py 71.88% 🙂 70.89% 🙂 -0.99% 👎
tests/common/integration_features/test_suppressions_integration.py 70.30% 🙂 68.97% 🙂 -1.33% 👎
tests/terraform/checks/resource/aws/test_CodeBuildEncrypted.py 86.69% ⭐ 86.69% ⭐ 0.00%
tests/terraform/checks/resource/aws/test_CodeBuildProjectEncryption.py 91.29% ⭐ 68.94% 🙂 -22.35% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
checkov/arm/runner.py Runner.run 114 ⛔ 626 ⛔ 22 ⛔ 3.26% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
checkov/kubernetes/runner.py Runner.run 189 ⛔ 881 ⛔ 15 😞 8.54% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
checkov/terraform/graph_builder/local_graph.py TerraformLocalGraph._build_edges 67 ⛔ 437 ⛔ 14 😞 11.88% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
checkov/arm/checks/resource/NSGRulePortAccessRestricted.py NSGRulePortAccessRestricted.scan_resource_conf 95 ⛔ 210 ⛔ 18 ⛔ 13.71% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
checkov/cloudformation/cfn_utils.py build_definitions_context 51 ⛔ 271 ⛔ 17 ⛔ 13.97% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.