Skip to content

Only use direct IO when opening with Default IOContext and using the hybrid directory #129530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

ChrisHegarty
Copy link
Contributor

This commit updates the DIO format so that it only use direct IO when opening with Default IOContext and using the hybrid directory. I also took the opportunity to better align the code with where we ultimately want to get to (what is in the lucene_snapshot branch).

relates #128697
closes #128799 #128800

@ChrisHegarty ChrisHegarty requested a review from thecoop June 17, 2025 09:18
@ChrisHegarty ChrisHegarty added >refactoring :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0 labels Jun 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ChrisHegarty ChrisHegarty merged commit 8ec65ef into elastic:main Jun 17, 2025
26 of 27 checks passed
@ChrisHegarty ChrisHegarty deleted the dio_merge_fix branch June 17, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ES818HnswBinaryQuantizedVectorsFormatTests testSimpleOffHeapSizeFSDir failing
3 participants