Skip to content

Accommodate hollow engine changes #129535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 20, 2025

Conversation

kingherc
Copy link
Contributor

@kingherc kingherc commented Jun 17, 2025

Field infos calculation method inside Engine, so it can be overriden in stateless if/as needed.

Relates ES-11457

@kingherc kingherc self-assigned this Jun 17, 2025
@kingherc kingherc added >non-issue :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed Indexing Meta label for Distributed Indexing team labels Jun 17, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 serverless-linked Added by automation, don't add manually labels Jun 17, 2025
@kingherc kingherc force-pushed the non-issue/ES-11457-fieldinfos branch 2 times, most recently from 59c3acb to 18c9836 Compare June 17, 2025 11:30
So it can be overriden in stateless if/as needed.

Relates ES-11457
@kingherc kingherc force-pushed the non-issue/ES-11457-fieldinfos branch from 18c9836 to a2d17e1 Compare June 17, 2025 11:49
@kingherc kingherc marked this pull request as ready for review June 17, 2025 13:27
@kingherc kingherc requested review from fcofdez and tlrx June 17, 2025 13:27
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingherc kingherc changed the title Field infos calculation method inside Engine Accommodate hollow engine changes Jun 19, 2025
@kingherc kingherc requested a review from fcofdez June 19, 2025 11:13
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingherc kingherc merged commit 2940f9a into elastic:main Jun 20, 2025
27 checks passed
@kingherc kingherc deleted the non-issue/ES-11457-fieldinfos branch June 20, 2025 13:02
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Jun 23, 2025
* Field infos calculation method inside Engine
* buildSeqNoStats as static public method

So it can be overriden in stateless if/as needed.

Relates ES-11457
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
* Field infos calculation method inside Engine
* buildSeqNoStats as static public method

So it can be overriden in stateless if/as needed.

Relates ES-11457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue serverless-linked Added by automation, don't add manually Team:Distributed Indexing Meta label for Distributed Indexing team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants