[8.19] Fix tests in IndexLifecycleServiceTests (#129449)
#129542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests were ineffective because the result of the countdown latch was ignored. Correctly asserting the output of the latch showed that the test was failing, which was due to missing test setup - the policies were not defined in the registry and the lifecycle runner didn't execute the cluster state steps due to a missing task queue. Finally, some test objects were constructed incorrectly likely due to typos. (cherry picked from commit d384e2f)
nielsbauman
added
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:IndexLifecycleServiceTests(#129449)Questions ?
Please refer to the Backport tool documentation