Skip to content

Fix generative tests #129833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Jun 23, 2025

Fixes: #129819

To small changes to make the tests more strict:

  • Make count_distinct() generation more consistent (only text/number/date fields for now, eg. to avoid unsupported fields)
  • Take known bugs into consideration when validating LOOKUP JOIN

@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL labels Jun 23, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jun 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila luigidellaquila enabled auto-merge (squash) June 23, 2025 08:45
@luigidellaquila luigidellaquila merged commit 085ef5c into elastic:main Jun 23, 2025
32 checks passed
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Jun 23, 2025
julian-elastic pushed a commit to julian-elastic/elasticsearch that referenced this pull request Jun 24, 2025
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] GenerativeIT test failing
3 participants