Fix S3 deletion bugs #129891
Open
Fix S3 deletion bugs #129891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug the first: `S3BlobContainer#delete` spuriously attempts to delete a blob named after the container, as if it were a directory in a filesystem. This makes sense for filesystem repositories but in S3 the blob key is an opaque string, may be a prefix of other blob keys, and can legitimately end in a `/`. We never create such a blob in the first place, but this was hidden because AWS S3 silently ignores these deletion requests, and also because... Bug the second: `S3HttpHandler` would delete extant blobs but ignore nonexistent blobs when processing a multi-object delete request. This is apparently how S3 behaves in practice but it's not documented as such so we cannot rely on it and must be stricter in our tests. Fixing this exposed... Bug the third: `S3BlobContainer#deleteBlobsIgnoringIfNotExists` wasn't actually ignoring `NoSuchKey` errors should any arise, and the S3 reference documentation does not proscribe this behaviour, so we must handle it properly.
DaveCTurner
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug the first:
S3BlobContainer#deletespuriously attempts to delete ablob named after the container, as if it were a directory in a
filesystem. This makes sense for filesystem repositories but in S3 the
blob key is an opaque string, may be a prefix of other blob keys, and
can legitimately end in a
/. We never create such a blob in the firstplace, but this was hidden because AWS S3 silently ignores these
deletion requests, and also because...
Bug the second:
S3HttpHandlerwould delete extant blobs but ignorenonexistent blobs when processing a multi-object delete request. This is
apparently how S3 behaves in practice but it's not documented as such so
we cannot rely on it and must be stricter in our tests. Fixing this
exposed...
Bug the third:
S3BlobContainer#deleteBlobsIgnoringIfNotExistswasn'tactually ignoring
NoSuchKeyerrors should any arise, and the S3reference documentation does not proscribe this behaviour, so we must
handle it properly.