Skip to content

Pass empty lists instead of nulls to FileAccessTree.of #129942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Jun 24, 2025

Fixes #129168.
Fixes #129167.

@prdoyle prdoyle self-assigned this Jun 24, 2025
@prdoyle prdoyle requested a review from a team as a code owner June 24, 2025 15:38
@prdoyle prdoyle added >non-issue auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Jun 24, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jun 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle enabled auto-merge (squash) June 24, 2025 17:02
@prdoyle prdoyle merged commit 0e23624 into elastic:main Jun 24, 2025
31 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Jun 24, 2025
@prdoyle prdoyle deleted the windows-nulls branch June 24, 2025 19:08
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] FileAccessTreeTests testWindowsAbsolutPathAccess failing [CI] FileAccessTreeTests testWindowsMixedCaseAccess failing
3 participants