Skip to content

Reverse disordered-version warning message #129956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DaveCTurner
Copy link
Contributor

The comment in TransportHandshaker indicates (correctly) that we emit
a warning when talking to a chronologically-newer-yet-numerically-older
version, but the wording of the warning message is inverted and says
that the remote is chronologically-older-yet-numerically-newer. This
commit straightens out the message to match the situation it is
describing.

Relates #123397
Backport of #129904 to 8.19

The comment in `TransportHandshaker` indicates (correctly) that we emit
a warning when talking to a chronologically-newer-yet-numerically-older
version, but the wording of the warning message is inverted and says
that the remote is chronologically-older-yet-numerically-newer. This
commit straightens out the message to match the situation it is
describing.

Relates elastic#123397
Backport of elastic#129904 to `8.19`
@DaveCTurner DaveCTurner added >bug :Core/Infra/Core Core issues without another label backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged v8.19.0 v8.18.4 labels Jun 24, 2025
@elasticsearchmachine elasticsearchmachine merged commit 82800f9 into elastic:8.19 Jun 24, 2025
22 checks passed
@DaveCTurner DaveCTurner deleted the 2025/06/24/backport-129904-819 branch June 24, 2025 18:46
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 24, 2025
The comment in `TransportHandshaker` indicates (correctly) that we emit
a warning when talking to a chronologically-newer-yet-numerically-older
version, but the wording of the warning message is inverted and says
that the remote is chronologically-older-yet-numerically-newer. This
commit straightens out the message to match the situation it is
describing.

Relates elastic#123397
Backport of elastic#129904 to `8.19`
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18

elasticsearchmachine pushed a commit that referenced this pull request Jun 24, 2025
The comment in `TransportHandshaker` indicates (correctly) that we emit
a warning when talking to a chronologically-newer-yet-numerically-older
version, but the wording of the warning message is inverted and says
that the remote is chronologically-older-yet-numerically-newer. This
commit straightens out the message to match the situation it is
describing.

Relates #123397
Backport of #129904 to `8.19`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Core/Infra/Core Core issues without another label v8.18.4 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants