Skip to content

[Entitlements] Small fix on relative_path docs #129984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

ldematte
Copy link
Contributor

No description provided.

@ldematte ldematte added >docs General docs changes v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Jun 25, 2025
Copy link
Contributor

github-actions bot commented Jun 25, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels Jun 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @ldematte! I couldn't resist a little copyedit 🤓. LMKWYT.

This section still felt a little repetitive. My suggestion nests relative_to under relative_path for clarity.

@ldematte
Copy link
Contributor Author

@leemthompo much better, thanks!

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs!

@@ -137,8 +137,8 @@ Allows code to access the filesystem, to read or write paths as specified by the

It is possible to specify 3 different types of file entitlement:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldematte final thought on this one: we could use numbered list for the 3 here to be even clearer :)

@ldematte ldematte enabled auto-merge (squash) June 25, 2025 10:45
@ldematte ldematte merged commit b52e5a7 into elastic:main Jun 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Entitlements Entitlements infrastructure >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants