-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Fix behavior for _index LIKE for ESQL #130019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julian-elastic
wants to merge
61
commits into
elastic:main
Choose a base branch
from
julian-elastic:indexLike_v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,104
−330
Open
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
6060269
Get basic case to work
julian-elastic 7dce974
Add ExpressionQueryBuilder with serialization
julian-elastic 4984c12
[CI] Auto commit changes from spotless
elasticsearchmachine 5a17cee
Get _index like working newToNew
elasticsearchmachine f34f352
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic 3ad0404
[CI] Auto commit changes from spotless
elasticsearchmachine 480db29
Move functionality from AutomatonTranslatable to TranslationAware
julian-elastic 7484410
Remove AutomatonQueryBuilder and EsqlAutomatonQuery
julian-elastic 77c541d
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic a8d5b44
Clean up
julian-elastic 541fc6d
Clean up and comments
julian-elastic 1664b6b
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic 55850ba
working on getting the tests to pass in bwc mode
julian-elastic fed0223
[CI] Auto commit changes from spotless
elasticsearchmachine 817336d
Merge branch 'main' into indexLike_v3
julian-elastic 521da24
Revert "Remove AutomatonQueryBuilder and EsqlAutomatonQuery"
julian-elastic faba3e0
Remove skipped check
julian-elastic 2f4bace
Fix unit tests failing
julian-elastic 5cef3fb
[CI] Auto commit changes from spotless
elasticsearchmachine 31c59d9
Fix transport protocol issues with the unit tests
julian-elastic ccafea4
Clean up classes no longer needed
julian-elastic 8d032fe
[CI] Auto commit changes from spotless
elasticsearchmachine bc11f30
bigfix
julian-elastic f31bbf4
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic b3f65ed
Fix more failing UTs
julian-elastic b6c162d
Merge branch 'main' into indexLike_v3
julian-elastic 4bb44b6
Fix more failing UTs
julian-elastic c51b759
[CI] Auto commit changes from spotless
elasticsearchmachine b6d26fb
Revert change in SearchShardsRequest
julian-elastic b3bb0b8
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic eb1deb9
Revert change in SearchShardsRequest
julian-elastic aff0fac
Address code review feedback part 1
julian-elastic 359a7c6
Merge branch 'main' into indexLike_v3
julian-elastic 0ce123c
Update docs/changelog/130019.yaml
julian-elastic f0b6e5a
Address code review feedback part 2 (still needs UT with the flag set…
julian-elastic 5c3d8b5
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic b619623
[CI] Auto commit changes from spotless
elasticsearchmachine b776435
UT fixes
julian-elastic 35544dd
Merge remote-tracking branch 'origin/indexLike_v3' into indexLike_v3
julian-elastic 29d14ac
Merge branch 'main' into indexLike_v3
julian-elastic bca38b2
Fix merge errors
julian-elastic 9cc0527
Add Supplier for Automaton and CharacterRunAutomaton
julian-elastic 5b852f0
Fix UT errors
julian-elastic 99364d7
Fix UT errors
julian-elastic a251c09
Change behavior for LIKE LIST and _index
julian-elastic 3aaa248
Plan serialization?
nik9000 bd1f56c
fixup
nik9000 e1eaf49
Merge remote-tracking branch 'julian-elastic/indexLike_v3' into index…
nik9000 7cd4f37
Address no commits
julian-elastic 3af20cc
Fix failing UTs
julian-elastic fb79e61
[CI] Auto commit changes from spotless
elasticsearchmachine f5b22f3
Merge branch 'main' into indexLike_v3
julian-elastic 238fd3b
Remove some debugging print statements
julian-elastic 288c86e
[CI] Auto commit changes from spotless
elasticsearchmachine 7d5b692
Move flag to EsqlFlags
nik9000 6d9ea08
Merge remote-tracking branch 'julian-elastic/indexLike_v3' into index…
nik9000 9758344
Clean up and fix UTs
julian-elastic 0996c39
[CI] Auto commit changes from spotless
elasticsearchmachine 0afe31a
Fix UT fail
julian-elastic 442ea48
Update docs/changelog/130019.yaml
julian-elastic 8540550
Address code review comments
julian-elastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
pr: 130019 | ||
summary: Fix behavior for `_index` LIKE for ESQL | ||
area: ES|QL | ||
type: bug | ||
issues: | ||
- 129511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 0 additions & 108 deletions
108
server/src/main/java/org/elasticsearch/index/query/AutomatonQueryBuilder.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.