[ESQL] Ensure date/date_nanos implicit casting rule behind snapshot #130026
+34
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fang-xing-esql
added
>bug
auto-backport
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
fang-xing-esql
commented
Jun 25, 2025
| @@ -1819,10 +1820,6 @@ private static boolean canConvertOriginalTypes(MultiTypeEsField multiTypeEsField | |||
|
|
|||
| private static Expression typeSpecificConvert(ConvertFunction convert, Source source, DataType type, InvalidMappedField mtf) { | |||
| EsField field = new EsField(mtf.getName(), type, mtf.getProperties(), mtf.isAggregatable()); | |||
| return typeSpecificConvert(convert, source, field); | |||
There was a problem hiding this comment.
This is a small refactor.
alex-spies
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Thanks @fang-xing-esql , only super minor comments - please go ahead at your own discretion.
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java
Outdated
Show resolved
Hide resolved
fang-xing-esql
added
v9.1.0
v9.1.1
and removed
test-release
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
|
The failed release tests are not relevant to this PR, removed the test-releases label. |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
alex-spies
reviewed
Jul 2, 2025
docs/changelog/130026.yaml
Outdated
Comment on lines
2
to
4
| summary: Ensure date/date_nanos implicit casting rule behind snapshot | ||
| area: ES|QL | ||
| type: bug |
There was a problem hiding this comment.
This re-appeared - I think you'll have to mark this PR as >non-issue, otherwise the bot will probably insist on the changelog entry.
fang-xing-esql
added a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Jul 2, 2025
…lastic#130026) * put date date_nanos implicit casting rule behind snapshot
fang-xing-esql
added a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Jul 2, 2025
…lastic#130026) * put date date_nanos implicit casting rule behind snapshot
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…lastic#130026) * put date date_nanos implicit casting rule behind snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130003
Ensure
date/date_nanosimplicit casting rule behind snapshot, when #127797 was merged, the ruleDateMillisToNanosInEsRelationwas not behind snapshot, and caused the release test above failed.