-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Fix: prevent duplication of "invalid index name" string in the final exception error message #130027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: prevent duplication of "invalid index name" string in the final exception error message #130027
Conversation
dropping asterisk in `IdentifierBuilder#resolveAndValidateIndex()`
Okay, so I found that the ordering of the invalid chars differed between |
Hi @pawankartik-elastic, I've created a changelog YAML for you. |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…exception error message (elastic#130027) * Use `throwInvalidIndexNameException()` to throw invalid ex after dropping asterisk in `IdentifierBuilder#resolveAndValidateIndex()` * Assert the message in test * Refactor * drop invalid chars from assertion string due to randomisation issue * Re-assert invalid chars * Update docs/changelog/130027.yaml
This is to prevent the duplication of "invalid index name" in the final exception error message:
Invalid index name [index_name_here], invalid index name ... must not contain the following characters ....
. I've already made the changes for 8.19 in the backport PR here: #130021.