Skip to content

Fix: prevent duplication of "invalid index name" string in the final exception error message #130027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pawankartik-elastic
Copy link
Contributor

This is to prevent the duplication of "invalid index name" in the final exception error message: Invalid index name [index_name_here], invalid index name ... must not contain the following characters ..... I've already made the changes for 8.19 in the backport PR here: #130021.

@pawankartik-elastic
Copy link
Contributor Author

pawankartik-elastic commented Jun 26, 2025

Okay, so I found that the ordering of the invalid chars differed between main and 8.19. Turns out, there's a missing sorted() for the invalid chars in Strings class in 8.19 and that was causing the test to fail there. I fixed it in the backport PR.

@pawankartik-elastic pawankartik-elastic marked this pull request as ready for review June 26, 2025 11:40
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jun 26, 2025
@pawankartik-elastic pawankartik-elastic added >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Jun 26, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jun 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @pawankartik-elastic, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pawankartik-elastic pawankartik-elastic merged commit 2667a2d into elastic:main Jun 26, 2025
32 checks passed
@pawankartik-elastic pawankartik-elastic deleted the pkar/drop-asterisk-invalid-chars-esql branch June 26, 2025 15:11
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 3, 2025
…exception error message (elastic#130027)

* Use `throwInvalidIndexNameException()` to throw invalid ex after
dropping asterisk in `IdentifierBuilder#resolveAndValidateIndex()`

* Assert the message in test

* Refactor

* drop invalid chars from assertion string due to randomisation issue

* Re-assert invalid chars

* Update docs/changelog/130027.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants