[ML] Support 8.19 + 9.1 clusters for all new inference providers #130033
Conversation
Overriding version support to include the 8.19 patch version.
prwhelan
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
changed the title
| @@ -118,6 +118,12 @@ public TransportVersion getMinimalSupportedVersion() { | |||
| return TransportVersions.ML_INFERENCE_HUGGING_FACE_RERANK_ADDED; | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean supportsVersion(TransportVersion version) { | |||
| return ServiceSettings.super.supportsVersion(version) | |||
There was a problem hiding this comment.
I think it'd be more clear to do version.onOrAfter(ML_INFERENCE_HUGGING_FACE_RERANK_ADDED) || version.isPatchFrom(ML_INFERENCE_HUGGING_FACE_RERANK_ADDED_8_19). Something like that.
There was a problem hiding this comment.
It's the same thing - but it's easier to scan it and make sure it's the same thing.
| @@ -82,6 +82,12 @@ public TransportVersion getMinimalSupportedVersion() { | |||
| return TransportVersions.AMAZON_BEDROCK_TASK_SETTINGS; | |||
There was a problem hiding this comment.
Optional/nitpick: I would change this to
throw Exception("should never be called when supportsVersion is used")
or so (see other classes).
There was a problem hiding this comment.
spoke offline - i agree with this but i'm scared to change to exceptions in case there is something in prod using this, so to keep 9.1+ clusters alive and fail in non-prod, we added assertions
prwhelan
added
the
auto-backport
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
…stic#130033) Overriding version support to include the 8.19 patch version.
…stic#130033) Overriding version support to include the 8.19 patch version.
Overriding version support to include the 8.19 patch version.