Add cloud API keys to auth info report #130041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
ankit--sethi
added
:Security/Security
elasticsearchmachine
added
Team:Security
|
Pinging @elastic/es-security (Team:Security) |
| String apiKeyId = randomAlphaOfLength(20); | ||
| Authentication authentication = AuthenticationTestHelper.randomCloudApiKeyAuthentication(apiKeyId); | ||
| String json = generateJson(Map.of(AuthenticationField.AUTHENTICATION_KEY, authentication.encode())); | ||
| assertThat(json, containsString("{\"authorization\":{\"cloud_api_key\":{\"id\":\"" + apiKeyId + "\"")); |
There was a problem hiding this comment.
Test only asserts id field. Using randomCloudApiKeyAuthentication(apiKeyId) may not be quite suitable here. Probably it's better to randomize User then call randomCloudApiKeyAuthentication(user). This way you can assert all fields as you control user's principal (API key id), metadata (name and internal) and roles.
There was a problem hiding this comment.
refactored the test and some helper methods to assert on a fully randomized user
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
* add change and test * improve test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.