[EIS] Rename the elser 2 default model and the default inference endpoint #130336
Conversation
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @timgrein, I've created a changelog YAML for you. |
…ence-endpoint' into rename-eis-elser-model-and-inference-endpoint
| @@ -41,7 +41,7 @@ public void testGetDefaultEndpoints() throws IOException { | |||
| } | |||
|
|
|||
| assertInferenceIdTaskType(allModels, ".rainbow-sprinkles-elastic", TaskType.CHAT_COMPLETION); | |||
| assertInferenceIdTaskType(allModels, ".elser-v2-elastic", TaskType.SPARSE_EMBEDDING); | |||
| assertInferenceIdTaskType(allModels, ".elser-2-elastic", TaskType.SPARSE_EMBEDDING); | |||
| assertInferenceIdTaskType(allModels, ".multilingual-embed-v1-elastic", TaskType.TEXT_EMBEDDING); | |||
| assertInferenceIdTaskType(allModels, ".rerank-v1-elastic", TaskType.RERANK); | |||
There was a problem hiding this comment.
Do we need to remove v from the text embedding and rerank default endpoint names too?
There was a problem hiding this comment.
Nope, we'll only do the adjustment for ELSER to be en par with the ML node
| static final String DEFAULT_ELSER_ENDPOINT_ID_V2 = defaultEndpointId(DEFAULT_ELSER_MODEL_ID_V2); | ||
| // elser-2 | ||
| static final String DEFAULT_ELSER_2_MODEL_ID = "elser_model_2"; | ||
| static final String DEFAULT_ELSER_ENDPOINT_ID_V2 = defaultEndpointId("elser-2"); |
There was a problem hiding this comment.
I don't love this mismatch, but I imagine there are some considerations you're keeping in mind. Does changing it have backwards compatibility ramifications? Trying to think what the impact is, but can't figure it out 😅
There was a problem hiding this comment.
I'm with you, it doesn't look great. But the goal here is to be consistent with how things are called in the ML node, at least for ELSER. The model is called .elser_model_2 and the inference endpoint is .elser-2-elasticsearch. If we expect people to migrate with less confusion, it's good if the names are similar.
Now, the name of the reranker is .rerank-v1. That's how we got here...
There was a problem hiding this comment.
backwards compatibility
These endpoints are not released yet, so we have the luxury of being able to change the name still.
There was a problem hiding this comment.
Ahh, gotcha. Thanks for the clarification!
We've decided to rename the default model and default inference endpoint for elser running EIS. This needs to be backported to
9.1and8.19and we consider it as a bug as multiple other places (will) depend on these new names