Add index version for match_only_text stored field in binary format #130363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>non-issue
auto-backport
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
jordan-powers
commented
Jun 30, 2025
Comment on lines
+576
to
+581
| if (storedFieldInBinaryFormat) { | ||
| final var bytesRef = new BytesRef(utfBytes.bytes(), utfBytes.offset(), utfBytes.length()); | ||
| context.doc().add(new StoredField(fieldType().storedFieldNameForSyntheticSource(), bytesRef)); | ||
| } else { | ||
| context.doc().add(new StoredField(fieldType().storedFieldNameForSyntheticSource(), value.string())); | ||
| } |
There was a problem hiding this comment.
Not 100% sure about this. Maybe we want to continue writing in binary format even for older indices? Since we already updated the mapper to handle mixed string and byteref values, we may as well take advantage of the throughput benefits?
There was a problem hiding this comment.
I think this way the logic is simpler? So maybe keep it like this? Indices will rollover at some point and then binary format will be used.
martijnvg
approved these changes
Jul 1, 2025
| @@ -178,6 +178,7 @@ private static Version parseUnchecked(String version) { | |||
| public static final IndexVersion UPGRADE_TO_LUCENE_10_2_2 = def(9_030_0_00, Version.LUCENE_10_2_2); | |||
| public static final IndexVersion SPARSE_VECTOR_PRUNING_INDEX_OPTIONS_SUPPORT = def(9_031_0_00, Version.LUCENE_10_2_2); | |||
| public static final IndexVersion DEFAULT_DENSE_VECTOR_TO_BBQ_HNSW = def(9_032_0_00, Version.LUCENE_10_2_2); | |||
| public static final IndexVersion MATCH_ONLY_TEXT_STORED_AS_BYTES = def(9_033_0_00, Version.LUCENE_10_2_2); | |||
There was a problem hiding this comment.
I think we should already add the 8.19 version (including logic) to this PR, which should make back porting easier.
Comment on lines
+576
to
+581
| if (storedFieldInBinaryFormat) { | ||
| final var bytesRef = new BytesRef(utfBytes.bytes(), utfBytes.offset(), utfBytes.length()); | ||
| context.doc().add(new StoredField(fieldType().storedFieldNameForSyntheticSource(), bytesRef)); | ||
| } else { | ||
| context.doc().add(new StoredField(fieldType().storedFieldNameForSyntheticSource(), value.string())); | ||
| } |
There was a problem hiding this comment.
I think this way the logic is simpler? So maybe keep it like this? Indices will rollover at some point and then binary format will be used.
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Jul 2, 2025
…lastic#130363) Follow-up to elastic#130049 to gate using the binary format for the stored field in match_only_text fields behind an index version.
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Jul 2, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 2, 2025
…ormat (#130363) (#130416) * Add index version for match_only_text stored field in binary format (#130363) Follow-up to #130049 to gate using the binary format for the stored field in match_only_text fields behind an index version. (cherry picked from commit a69c484) # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java * Fix IndexVersion in testLoadSyntheticSourceFromStringOrBytesRef * Trigger build for auto-merge
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 2, 2025
…lastic#130363) Follow-up to elastic#130049 to gate using the binary format for the stored field in match_only_text fields behind an index version.
jordan-powers
added a commit
that referenced
this pull request
Jul 2, 2025
Accidentally used the wrong backport index version in #130363.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…lastic#130363) Follow-up to elastic#130049 to gate using the binary format for the stored field in match_only_text fields behind an index version.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Accidentally used the wrong backport index version in elastic#130363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #130049 to gate using the binary format for the stored field in match_only_text fields behind an index version (as we should have from the start).