Add pattern_text feature flag to logsdb yaml tests #130399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
jordan-powers
approved these changes
Jul 1, 2025
Comment on lines
44
to
46
| - requires: | ||
| cluster_features: [ "mapper.patterned_text" ] | ||
| reason: "patterned_text mappings are used in this test" |
There was a problem hiding this comment.
I think the setup: block runs before each test in the file, so you don't need this here since you have the check in the setup. But it also doesn't hurt anything to leave it.
There was a problem hiding this comment.
Yeah I think you're correct. It's cleaner to remove it 👍
parkertimmins
added
>non-issue
:StorageEngine/Mapping
elasticsearchmachine
added
Team:StorageEngine
and removed
needs:triage
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
...n/logsdb/src/yamlRestTest/resources/rest-api-spec/test/patternedtext/20_synthetic_source.yml
Show resolved
Hide resolved
|
Btw, you might want to backport this to the 9.1 branch |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Jul 2, 2025
Patterned text yaml tests in logsdb plugin are failing as they assume the presence of the pattern_text type. Enable the feature flag for the tests. (cherry picked from commit b38d545)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 2, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Patterned text yaml tests in logsdb plugin are failing as they assume the presence of the pattern_text type. Enable the feature flag for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patterned text yaml tests in logsdb plugin are failing as they assume the presence of the pattern_text type. Enable the feature flag for the tests.
Fixes #130376 (comment)