Fix sampling for kmeans and address assignment edge case #130405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
requested review from
iverase and
john-wagster
and removed request for
iverase
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
benwtrent
added
the
auto-merge-without-approval
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 2, 2025
) This is three fixes: - We should be doing actual sampling when doing kmeans clustering, taking the first N vectors creates some weird edge cases - Having assignments initialized as `0` means that if a vector gets assigned to cluster ord `0`, that cluster centroid actually isn't updated later in the lloyd steps. So, this initializes assignments to -1 - If we actually don't sample the vectors for lloyd, don't bother with final pass to potentially update the centroids
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
) This is three fixes: - We should be doing actual sampling when doing kmeans clustering, taking the first N vectors creates some weird edge cases - Having assignments initialized as `0` means that if a vector gets assigned to cluster ord `0`, that cluster centroid actually isn't updated later in the lloyd steps. So, this initializes assignments to -1 - If we actually don't sample the vectors for lloyd, don't bother with final pass to potentially update the centroids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is three fixes:
0means that if a vector gets assigned to cluster ord0, that cluster centroid actually isn't updated later in the lloyd steps. So, this initializes assignments to -1