Segregate test methods in ThreadPoolMergeExecutorServiceDiskSpaceTests wrt to the mocked filesystems #130430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>test
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
albertzaharovits
commented
Jul 2, 2025
Comment on lines
+102
to
+107
| if (setThreadPoolMergeSchedulerSetting) { | ||
| assertWarnings( | ||
| "[indices.merge.scheduler.use_thread_pool] setting was deprecated in Elasticsearch " | ||
| + "and will be removed in a future release. See the breaking changes documentation for the next major version." | ||
| ); | ||
| } |
There was a problem hiding this comment.
Unrelated change that consolidates warning headers assertions.
albertzaharovits
commented
Jul 2, 2025
| @@ -564,7 +556,7 @@ public void testAbortingOrRunningMergeTaskHoldsUpBudget() throws Exception { | |||
| testDoneLatch.await(); | |||
| return null; | |||
| }).when(stallingMergeTask).abort(); | |||
| threadPoolMergeExecutorService.submitMergeTask(stallingMergeTask); | |||
| assertTrue(threadPoolMergeExecutorService.submitMergeTask(stallingMergeTask)); | |||
There was a problem hiding this comment.
Unrelated change, just to make sure nothing unexpectedly fails when submitting a merge task.
albertzaharovits
added
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jul 3, 2025
Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class. But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods. This PR recreates the mocked filesystems for every test method. Fixes elastic#129296 elastic#130205
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jul 3, 2025
Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class. But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods. This PR recreates the mocked filesystems for every test method. Fixes elastic#129296 elastic#130205
albertzaharovits
added a commit
that referenced
this pull request
Jul 3, 2025
…iskSpaceTests wrt to the mocked filesystems (#130430) #130524 Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class. But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods. This PR recreates the mocked filesystems for every test method. Fixes #129296 #130205
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 3, 2025
…iskSpaceTests wrt to the mocked filesystems (#130430) (#130522) * assertTrue for submitMergeTask (#130430) Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class. But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods. This PR recreates the mocked filesystems for every test method. Fixes #129296 #130205 * Ooops the warning response headers are different
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 3, 2025
Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class. But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods. This PR recreates the mocked filesystems for every test method. Fixes #129296 #130205
This was referenced Jul 3, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class. But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods. This PR recreates the mocked filesystems for every test method. Fixes elastic#129296 elastic#130205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, out of zealousness for testing efficiency, the mocked filesystems were reused across the test suite class.
But this makes tests liable to interference wrt to filesystem stats calls. Moreover, if one test fails, it can trigger failures in other test methods.
This PR recreates the mocked filesystems for every test method.
Fixes #129296 #130205