Skip to content

Fix bwc tests failures introduced in #130254 #130441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carlosdelest
Copy link
Member

#130254 introduced a new test cluster feature to check that #130239 was fixed.

However, rolling upgrade tests cannot work due to upgraded nodes unable to join the cluster, as 9.x does not have this feature.

This PR marks the test feature as assumed for next compatibility boundary, effectively assuming new versions have that feature.

Relates to #130254

…patibility version, as this bug is fixed on Lucene 10 / ES 9.x
@carlosdelest carlosdelest requested review from thecoop and benwtrent July 2, 2025 09:47
@carlosdelest carlosdelest added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.19.0 v8.19.1 labels Jul 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thecoop thecoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature is not applicable for 9.x, so this is assumed

@benwtrent benwtrent merged commit 69aea62 into elastic:8.19 Jul 2, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.19.0 v8.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants