Skip to content

* Natuve float type + proper QueryPragmas propagation #130450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shmuelhanoch
Copy link
Contributor

@shmuelhanoch shmuelhanoch commented Jul 2, 2025

  • Added a flag for ESQL's DataType's widenSmallType, to control to widening of floats

  • Threaded QueryPragmas into any place in theh code which eventually calls widenSmallType, to allow conditioning the float widening on the session / query specific pragmas.

  • For now, provided QueryPragmas.EMPTY as a hard coded argument for all the tests that now needs pragmas because of those changes. Ideally, next thing should be to inject pragmas into the tests from a single place, and using a Gradle command parameter. This will make sure that all the tests are running with the same pragmas values, and ` avoid redyndant degrees of freedom where each test manually pass its own value.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@shmuelhanoch shmuelhanoch force-pushed the esql_native_float_type_pragma branch from ae269f6 to f169e97 Compare July 2, 2025 11:43
…g of floats to doubles (the current default behavior).

* Added a flag for ESQL's DataType's `widenSmallType`, to control to widening of floats

* Threaded QueryPragmas into any place in theh code which eventually calls `widenSmallType`, to allow conditioning the
  float widening on the session / query specific pragmas.

* For now, provided `QueryPragmas.EMPTY` as a hard coded argument for all the tests that now needs pragmas because
  of those changes. Ideally, next thing should be to inject pragmas into the tests from a single place, and using
  a Gradle command parameter. This will make sure that all the tests are running with the same pragmas values, and `
  avoid redyndant degrees of freedom where each test manually pass its own value.
@shmuelhanoch shmuelhanoch force-pushed the esql_native_float_type_pragma branch from f169e97 to 2348726 Compare July 2, 2025 12:01
@shmuelhanoch shmuelhanoch changed the title * Added a new ESQL query pragma:, NATIVE_FLOAT_TYPE, to avoid widenin… * Natuve float type + proper QueryPragmas propagation Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants