Skip to content

Cleanup on standardizing elasticsearch classifier in artifact names #130473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jul 2, 2025

We want to sync across the stack on architecture naming and artifact names
containing architecture information

@breskeby breskeby requested a review from a team as a code owner July 2, 2025 14:50
@breskeby breskeby added :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team auto-backport Automatically create backport pull requests when merged v9.0.4 v8.18.4 v8.17.9 v9.2.0 v9.1.1 v8.19.1 labels Jul 2, 2025
@breskeby breskeby self-assigned this Jul 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Jul 2, 2025
@alina-bacalete
Copy link

alina-bacalete commented Jul 2, 2025

Linking here the follow-up infra PR: https://github.com/elastic/infra/pull/42419 for reference (I'll add soon a commit to also update for the recently added 9.1 branch)
We'll also need to sync when merging so that we can merge the infra PR after this one and then the unified-release PR once the infra one is merged. Thank you in advance!

@breskeby
Copy link
Contributor Author

breskeby commented Jul 3, 2025

@alina-bacalete fyi. this is a bit more complex in elasticsearch as our update tests use code from other version branches. I'm not sure we can migrate all branches at ones. I initially try to get main running and we can see from there.

@breskeby breskeby force-pushed the standardize-amd64-artifact-names branch 2 times, most recently from f82d90b to bc8e3ed Compare July 3, 2025 14:55
@breskeby breskeby requested a review from a team as a code owner July 3, 2025 14:55
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby force-pushed the standardize-amd64-artifact-names branch 2 times, most recently from db63da4 to 5547c10 Compare July 4, 2025 15:28
@breskeby breskeby changed the title Standardize elasticsearch amd64 image artifact names Cleanup on standardizing elasticsearch classifier in artifact names Jul 4, 2025
@breskeby
Copy link
Contributor Author

breskeby commented Jul 4, 2025

@alina-bacalete this ended up being way more refactoring in our interrnals than just renaming the docker context artifacts. I stepped back again and took another look and decided to cover the plain renaming in a simpler PR here: #130643

The idea is that we can easily apply this fix with a way smaller surface easier on all active branches and not block you with our shenigans on cleaning up / refactoring build internals

@breskeby breskeby force-pushed the standardize-amd64-artifact-names branch from 2eb2e0e to 610108c Compare July 4, 2025 15:47
@breskeby breskeby force-pushed the standardize-amd64-artifact-names branch from 610108c to ae901ea Compare July 4, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >non-issue Team:Delivery Meta label for Delivery team v8.17.9 v8.18.4 v8.19.1 v9.0.4 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants