-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Cleanup on standardizing elasticsearch classifier in artifact names #130473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/es-delivery (Team:Delivery) |
Linking here the follow-up infra PR: https://github.com/elastic/infra/pull/42419 for reference (I'll add soon a commit to also update for the recently added 9.1 branch) |
@alina-bacalete fyi. this is a bit more complex in elasticsearch as our update tests use code from other version branches. I'm not sure we can migrate all branches at ones. I initially try to get main running and we can see from there. |
f82d90b
to
bc8e3ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
db63da4
to
5547c10
Compare
@alina-bacalete this ended up being way more refactoring in our interrnals than just renaming the docker context artifacts. I stepped back again and took another look and decided to cover the plain renaming in a simpler PR here: #130643 The idea is that we can easily apply this fix with a way smaller surface easier on all active branches and not block you with our shenigans on cleaning up / refactoring build internals |
2eb2e0e
to
610108c
Compare
We want to sync across the stack on architecture naming and artifact names containing architecture information
610108c
to
ae901ea
Compare
We want to sync across the stack on architecture naming and artifact names
containing architecture information