Skip to content

IVFVectorsFormat doesn't report off-heap stats at the moment #130553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2025
Merged

IVFVectorsFormat doesn't report off-heap stats at the moment #130553

merged 3 commits into from
Jul 4, 2025
+21 −0

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Jul 3, 2025 •
edited
Loading

Override the assert method to check for 0, as IVF doesn't support off-heap stats on lucene 10.3 at the moment

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v9.2.0 labels Jul 3, 2025
@thecoop thecoop marked this pull request as ready for review July 4, 2025 09:29
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@thecoop thecoop requested a review from benwtrent July 4, 2025 10:59
ChrisHegarty
ChrisHegarty approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 9d07a11 into elastic:lucene_snapshot Jul 4, 2025
29 of 34 checks passed
@thecoop thecoop deleted the ivf-vectors-format-offheap-stats branch July 4, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@benwtrent benwtrent Awaiting requested review from benwtrent

Assignees
No one assigned
Labels
:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecoop @elasticsearchmachine @ChrisHegarty