Skip to content

Fix msearch rest-api-spec #130627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 4, 2025

The code that reads these parameters is a bit scattered:

I've tested that all those parameters are accepted.

@pquentin pquentin added >non-issue auto-backport Automatically create backport pull requests when merged Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations v9.0.4 v8.18.4 v9.2.0 v9.1.1 v8.19.1 labels Jul 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, how did this come up?

In general, when I see this type of changes, my first reaction is "oh, does this really work?". I think adding a small yaml test for each of the new parameters would help increase that confidence.

@pquentin
Copy link
Member Author

pquentin commented Jul 7, 2025

Thanks for fixing this, how did this come up?

I'm working on fixing the inconsistencies between https://github.com/elastic/elasticsearch-specification and rest-api-spec (as tracked in elastic/elasticsearch-specification#4796) in order to ultimately generate the rest-api-spec from the Elasticsearch specification. The broader context is that we're working towards moving the Elasticsearch specification to Elasticsearch itself.

I understand why you would want a small YAML test, but it's not easy for me to do, especially as I'm currently dealing with 40 similar errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.18.4 v8.19.1 v9.0.4 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants