Add @UpdateForV10 to AbstractObjectParser.declareInt #130738
Draft
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an `@UpdateForV10` annotation to the `AbstractObjectParser .declareInt` method and assigns it to the Distributed Coordination team. This method needs to throw an `IllegalArgumentException` for non-integer values being passed, such as floats, doubles, and stringified floats and doubles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
@UpdateForV10annotation to theAbstractObjectParser .declareIntmethod and assigns it to the Distributed Coordination team. This method needs to throw anIllegalArgumentExceptionfor non-integer values being passed, such as floats, doubles, and stringified floats and doubles. At present, such values are truncated and accepted, and this may lead to undesired behaviour.