Don't check TSDB end time in YAML test #130761
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end time of a TSDB data stream is updated by `UpdateTimeSeriesRangeService` every 5 minutes. This means that every once in a while the test fails if UpdateTimeSeriesRangeService happens to have run during the test. This PR gets rid of this check. It's a bit odd that this failure hasn't shown up before (i.e. outside of the multi-project test suite), but I suspect it's related to the race condition we're seeing here - the MP test suite is likely a bit slower, making it slightly more likely to occur, perhaps. Resolves elastic#124575
nielsbauman
added
>test
elasticsearchmachine
added
v9.2.0
Team:Data Management
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Jul 7, 2025
|
I just realized that the cause is probably that we run these tests with a slightly different setup in the MP test suite. The data streams module has its own dedicated YAML test suite, but we're simply throwing it on a heap of YAML tests when we run the MP YAML test suite (with a slightly different cluster configuration). That will change in the future (every test suite will run in MP mode on its own, instead of running one big MP suite). I still think it's fine to merge this fix (instead of just muting the test in MP temporarily), as it still feels like a race condition to me. |
|
This fix makes sense to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end time of a TSDB data stream is updated by
UpdateTimeSeriesRangeServiceevery 5 minutes. This means that every once in a while the test fails if UpdateTimeSeriesRangeService happens to have run during the test. This PR gets rid of this check.It's a bit odd that this failure hasn't shown up before (i.e. outside of the multi-project test suite), but I suspect it's related to the race condition we're seeing here - the MP test suite is likely a bit slower, making it slightly more likely to occur, perhaps.
Resolves #124575