Fix msearch request parsing when index expression is null #130776
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalyshev
changed the title
smalyshev
added
:Search Foundations/Search
|
Hi @smalyshev, I've created a changelog YAML for you. |
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
reviewed
Jul 8, 2025
| @@ -537,6 +538,14 @@ public void testFailOnExtraCharacters() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| public void testNullIndex() throws IOException { | |||
| try { | |||
| MultiSearchRequest request = parseMultiSearchRequest("/org/elasticsearch/action/search/msearch-null.json"); | |||
There was a problem hiding this comment.
This is a case of personal preference, but have you considered inlining the JSON directly?
Since the request is only a couple of lines, inlining it would improve readability and make the test easier to follow at a glance, especially for a simple case like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
XContentMapValues.nodeStringArrayValuedoes not check for null before trying to manipulate the value, butnullis a legit value that can come from JSON, we should check for it.Fixes #129631