feat: improved manual #9940
Merged
feat: improved manual #9940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
gitKrystan
reviewed
Apr 17, 2025
gitKrystan
reviewed
Apr 17, 2025
gitKrystan
reviewed
Apr 17, 2025
gitKrystan
reviewed
Apr 17, 2025
gitKrystan
reviewed
Apr 17, 2025
guides/manual/1-overview.md
Outdated
|
|
||
| // ... | ||
|
|
||
| const editable = await user[Checkout](); |
There was a problem hiding this comment.
This might be confusing for junior devs. Can we provide an API like await checkout(user)?
There was a problem hiding this comment.
I dislike it for a different reason (requiring the import). I've considered adding await store.checkoutRecord(user) but checkout is an implementation detail of SchemaRecord currently, we'd have to consider whether this is a permanent addition of a feature that all potential record classes must support and if so what the contract is
gitKrystan
reviewed
Apr 17, 2025
gitKrystan
reviewed
Apr 17, 2025
runspired
force-pushed
the
docs-tweaks
branch
3 times, most recently
from
e75b90a to
ed01019
Compare
runspired
force-pushed
the
docs-tweaks
branch
3 times, most recently
from
d208bde to
aa1c815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on improving the new guide to cover more ground in an easier to digest way
Rendered